Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1279572

Re: [PATCH] net: fec: fix enet_out clock handling

From Lothar Waßmann <LW@KARO-electronics.de>
Newsgroups linux.kernel
Subject Re: [PATCH] net: fec: fix enet_out clock handling
Date 2015-11-30 06:40 +0100
Message-ID <qAplT-7SF-1@gated-at.bofh.it> (permalink)
References <qzrSO-3Uz-5@gated-at.bofh.it> <qAm4G-5Jv-9@gated-at.bofh.it>
Organization Ka-Ro electronics GmbH

Show all headers | View raw


Hi,

> On Fri, Nov 27, 2015 at 02:39:10PM +0100, Lothar Waßmann wrote:
> > When ENET_OUT is being used as reference clock for an external PHY,
> > the clock must not be disabled while the PHY is active. Otherwise the
> > PHY may lose its internal state and require a reset to become
> > functional again.
> > 
> > A symptom for this bug is a network interface that constantly toggles
> > between UP and DOWN state:
> > fec 800f0000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
> > fec 800f0000.ethernet eth0: Link is Down
> > fec 800f0000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
> > fec 800f0000.ethernet eth0: Link is Down
> 
> Hi Lothar
> 
> When does this up/down happen? During normal operation when the link
> is administrative up?
> 
If booting with NFSROOT the rootfs cannot be mounted, because when the
interface is brought up the PHY starts toggling the link state.

> When did this start happening? Did it happen before 
> 8fff755e9f8d net: fec: Ensure clocks are enabled while using mdio bus
> 
No. The behaviour started exactly with this commit.

Lothar Waßmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] net: fec: fix enet_out clock handling Lothar Waßmann <LW@KARO-electronics.de> - 2015-11-27 15:10 +0100
  Re: [PATCH] net: fec: fix enet_out clock handling Michael Heimpold <michael.heimpold@i2se.com> - 2015-11-27 16:30 +0100
  RE: [PATCH] net: fec: fix enet_out clock handling Duan Andy <fugang.duan@freescale.com> - 2015-11-28 14:20 +0100
    Re: [PATCH] net: fec: fix enet_out clock handling Andrew Lunn <andrew@lunn.ch> - 2015-11-28 17:50 +0100
      Re: [PATCH] net: fec: fix enet_out clock handling Andrew Lunn <andrew@lunn.ch> - 2015-11-30 03:00 +0100
      RE: [PATCH] net: fec: fix enet_out clock handling Duan Andy <fugang.duan@freescale.com> - 2015-11-30 03:20 +0100
    Re: [PATCH] net: fec: fix enet_out clock handling Lothar Waßmann <LW@KARO-electronics.de> - 2015-11-30 08:00 +0100
      RE: [PATCH] net: fec: fix enet_out clock handling Duan Andy <fugang.duan@freescale.com> - 2015-11-30 08:40 +0100
  Re: [PATCH] net: fec: fix enet_out clock handling Andrew Lunn <andrew@lunn.ch> - 2015-11-30 03:10 +0100
    Re: [PATCH] net: fec: fix enet_out clock handling Lothar Waßmann <LW@KARO-electronics.de> - 2015-11-30 06:40 +0100

csiph-web