[PATCH] bugfix oom kill init lead panic

Path	csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	<chenjie6@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH] bugfix oom kill init lead panic
Date	Mon, 30 Nov 2015 04:00:01 +0100
Message-ID	<qAmR3-613-3@gated-at.bofh.it> (permalink)
X-Original-To	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, <David.Woodhouse@intel.com>, <zhihui.gao@huawei.com>
X-Mailer	git-send-email 1.8.0
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.67.54.28]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020204.565BB98D.001B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	bdafbd1035eec7c76b5cb653a43924fa
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	<chenjie6@huawei.com>, <lizefan@huawei.com>, <akpm@linux-foundation.org>, <stable@vger.kernel.org>
X-Original-Date	Mon, 30 Nov 2015 18:54:29 +0800
X-Original-Message-ID	<1448880869-20506-1-git-send-email-chenjie6@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1279543

Show key headers only | View raw

From: chenjie <chenjie6@huawei.com>

when oom happened we can see:
Out of memory: Kill process 9134 (init) score 3 or sacrifice child                  
Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
Kill process 1 (init) sharing same memory
...
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009

That's because:
	the busybox init will vfork a process,oom_kill_process found
the init not the children,their mm is the same when vfork.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chen Jie <chenjie6@huawei.com>

---
 mm/oom_kill.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 4d87d7c..de77cbc 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -513,7 +513,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
 	rcu_read_lock();
 	for_each_process(p)
 		if (p->mm == mm && !same_thread_group(p, victim) &&
-		    !(p->flags & PF_KTHREAD)) {
+		    !(p->flags & PF_KTHREAD) && !is_global_init(p)) {
 			if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
 				continue;
 
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bugfix oom kill init lead panic <chenjie6@huawei.com> - 2015-11-30 04:00 +0100
  Re: [PATCH] bugfix oom kill init lead panic Andrew Morton <akpm@linux-foundation.org> - 2015-11-30 04:10 +0100
    Re: [PATCH] bugfix oom kill init lead panic "Chenjie (K)" <chenjie6@huawei.com> - 2015-11-30 04:40 +0100
      Re: [PATCH] bugfix oom kill init lead panic David Rientjes <rientjes@google.com> - 2015-11-30 23:10 +0100
        Re: [PATCH] bugfix oom kill init lead panic "Chenjie (K)" <chenjie6@huawei.com> - 2015-12-01 05:20 +0100
  Re: [PATCH] bugfix oom kill init lead panic David Rientjes <rientjes@google.com> - 2015-12-02 00:50 +0100

csiph-web