Re: [PATCH 2/3] ste_dma40: Delete another unnecessary check in d40_probe()

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] ste_dma40: Delete another unnecessary check in d40_probe()
Date	2015-11-29 22:30 +0100
Message-ID	<qAhHH-2TW-1@gated-at.bofh.it> (permalink)
References	(14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qvzvz-4cE-5@gated-at.bofh.it> <qvzvz-4cE-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 16, 2015 at 10:24 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 16 Nov 2015 21:56:07 +0100
>
> A single jump label was used by the d40_probe() function in several cases
> for error handling which was a bit inefficient here.
>
> * This implementation detail could be improved by the introduction
>   of another jump label.
>
> * Remove an extra check for the variable "base".
>
> * Omit its explicit initialisation at the beginning then.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] ste_dma40: Delete another unnecessary check in  d40_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-16 22:30 +0100
  Re: [PATCH 2/3] ste_dma40: Delete another unnecessary check in d40_probe() Linus Walleij <linus.walleij@linaro.org> - 2015-11-29 22:30 +0100

csiph-web