Re: [PATCH] mtd: nand: fix ONFI parameter page layout

Path	csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: fix ONFI parameter page layout
Date	Tue, 01 Dec 2015 20:10:02 +0100
Message-ID	<qAYtk-5dB-15@gated-at.bofh.it> (permalink)
References	<qxWxI-tE-7@gated-at.bofh.it> <qAD5v-8hq-5@gated-at.bofh.it> <qAPzJ-7P8-25@gated-at.bofh.it>
X-Original-To	Boris Brezillon <boris.brezillon@free-electrons.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=adunhOwu/8DD9/HQ22KBroMfed/7c8vx7sVt5aRadfA=; b=AccEY1jGCIfMyI+/c9ispSnAP3GYQiKDoiVof0Zmob/KV0GnRlTEYP9vXoFjZM5PvV KQhVA07ka+vWwNu9lsnmNJHpgydwhmbKw7EhU0ElF40Mia71WaHViri/jE0dxPeJC8Dm o2RtN9zd39LlOn+D8wbbBK04CyePwmtLZoZr3wEAuBxQj9cl7nrYtqqu77CsQvyaEk7p i4RU/M06g6IIAIWGavDGYfLxvRzjj8i3xDMkndk0RZhem0HkKpTsDwjJmmrb6cEc9gDD F7CbJrVxiNxXqE1gRD9mt+pdirZTXyRYMdc8QTJe4dASCoa/V2kUUkAQF2XHJjDJwCST f9xQ==
X-Received	by 10.98.2.210 with SMTP id 201mr81471700pfc.129.1448996713307; Tue, 01 Dec 2015 11:05:13 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	David Woodhouse <dwmw2@infradead.org>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org
X-Original-Date	Tue, 1 Dec 2015 11:05:10 -0800
X-Original-Message-ID	<20151201190510.GY64635@google.com>
X-Original-References	<1448274187-22174-1-git-send-email-boris.brezillon@free-electrons.com> <20151130201729.GK64635@google.com> <20151201103318.16a2e46a@bbrezillon>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1281132

Show key headers only | View raw

On Tue, Dec 01, 2015 at 10:33:18AM +0100, Boris Brezillon wrote:
> On Mon, 30 Nov 2015 12:17:29 -0800
> Brian Norris <computersforpeace@gmail.com> wrote:
> > On Mon, Nov 23, 2015 at 11:23:07AM +0100, Boris Brezillon wrote:
> > > src_ssync_features field is only 1 byte large, and the 4th reserved area
> > > is actually 8 bytes large.
> > > 
> > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > > Fixes d1e1f4e42b5 ("mtd: nand: add support for reading ONFI parameters from NAND device")
> > > Cc: <stable@vger.kernel.org> #v2.6.37+
> > 
> > Did you see an actual problem from this? (And is this deserving of
> > stable?) I could imagine an out-of-tree driver might try to use t_ald
> > (which should actually be t_adl, right?)
> 
> Yes, should be t_adl, not t_ald. Do you want me to send another patch
> for that, or will you take care of it?

I'll send a quick patch.

> > and get the wrong value. But no
> > one does that in-tree yet.
> 
> Fair enough, we can just drop the stable and fixes tag. Do you want me
> to resend it?

I presume this means you didn't see any actual problems caused by this
patch, other than new development referencing it?

Applied without the stable tag. I kept the fixes tag.

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] mtd: nand: fix ONFI parameter page layout Brian Norris <computersforpeace@gmail.com> - 2015-11-30 21:20 +0100
  Re: [PATCH] mtd: nand: fix ONFI parameter page layout Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-12-01 10:40 +0100
    Re: [PATCH] mtd: nand: fix ONFI parameter page layout Brian Norris <computersforpeace@gmail.com> - 2015-12-01 20:10 +0100
      Re: [PATCH] mtd: nand: fix ONFI parameter page layout Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-12-01 20:20 +0100

csiph-web