Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281064

Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size

Show all headers | View raw

On Tue, Dec 01, 2015 at 11:28:32AM +0100, Arnd Bergmann wrote:
> On Tuesday 01 December 2015 11:14:58 Stanimir Varbanov wrote:
> > 
> > diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
> > index 0f06f3b7a72b..6d290de9ab2b 100644
> > --- a/drivers/dma/qcom_bam_dma.c
> > +++ b/drivers/dma/qcom_bam_dma.c
> > @@ -458,7 +458,7 @@ static void bam_chan_init_hw(struct bam_chan *bchan,
> >          */
> >         writel_relaxed(ALIGN(bchan->fifo_phys, sizeof(struct bam_desc_hw)),
> >                         bam_addr(bdev, bchan->id, BAM_P_DESC_FIFO_ADDR));
> > -       writel_relaxed(BAM_DESC_FIFO_SIZE,
> > +       writel_relaxed(BAM_MAX_DATA_SIZE,
> >                         bam_addr(bdev, bchan->id, BAM_P_FIFO_SIZES));
> >  
> >         /* enable the per pipe interrupts, enable EOT, ERR, and INT irqs */
> 
> I'm looking at that now and fail to see why these have to use writel_relaxed().

At some point I believe I got a comment about using (readl/writel)_relaxed
instead of readl/writel.  So I used these instead.  Has the wind direction
changed?  =)

Using the readl/writel is nice w.r.t. having the implicit barriers, especially
with the funky 1K boundary on reordering of operations that can occur on Kraits.
This can hit you on accesses even within the same IP block.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2015-12-01 10:20 +0100
  Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Arnd Bergmann <arnd@arndb.de> - 2015-12-01 11:30 +0100
    Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Andy Gross <agross@codeaurora.org> - 2015-12-01 18:30 +0100
      Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Arnd Bergmann <arnd@arndb.de> - 2015-12-01 21:30 +0100
  Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Andy Gross <agross@codeaurora.org> - 2015-12-01 18:30 +0100
    Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2015-12-02 17:50 +0100
      Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Andy Gross <agross@codeaurora.org> - 2015-12-02 18:30 +0100
        Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2015-12-10 14:20 +0100

csiph-web