Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281057

Re: [PATCH v3 1/3] resource: Add @flags to region_intersects()

Show all headers | View raw

On Tue, Dec 1, 2015 at 9:13 AM, Borislav Petkov <bp@alien8.de> wrote:
>
> Oh sure, I didn't mean you. I was simply questioning that whole
> identify-resource-by-its-name approach. And that came with:
>
> 67cf13ceed89 ("x86: optimize resource lookups for ioremap")
>
> I just think it is silly and that we should be identifying resource
> things in a more robust way.

I could easily imagine just adding a IORESOURCE_RAM flag (or SYSMEM or
whatever). That sounds sane. I agree that comparing the string is
ugly.

> Btw, the ->name thing in struct resource has been there since a *long*
> time

It's pretty much always been there.  It is indeed meant for things
like /proc/iomem etc, and as a debug aid when printing conflicts,
yadda yadda. Just showing the numbers is usually useless for figuring
out exactly *what* something conflicts with.

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Borislav Petkov <bp@alien8.de> - 2015-12-01 15:00 +0100
  Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Dan Williams <dan.j.williams@intel.com> - 2015-12-01 18:00 +0100
    Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Jeff Moyer <jmoyer@redhat.com> - 2015-12-01 18:10 +0100
    Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-01 18:20 +0100
      Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Toshi Kani <toshi.kani@hpe.com> - 2015-12-03 19:00 +0100
        Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Borislav Petkov <bp@alien8.de> - 2015-12-03 19:50 +0100
          Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-03 20:10 +0100
            Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Toshi Kani <toshi.kani@hpe.com> - 2015-12-03 20:50 +0100
              Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Dan Williams <dan.j.williams@gmail.com> - 2015-12-09 17:30 +0100
                Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Toshi Kani <toshi.kani@hpe.com> - 2015-12-09 22:50 +0100
    Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() Borislav Petkov <bp@alien8.de> - 2015-12-01 18:20 +0100

csiph-web