Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280961

Re: [PATCH v3 3/3] ARM: amba: Properly handle devices with power domains

Show all headers | View raw

On 1 December 2015 at 14:34, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> To read pid/cid registers, the probed device need to be properly turned on.
> When it is inside a power domain, the bus code should ensure that the
> given power domain is enabled before trying to access device's registers.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
>  drivers/amba/bus.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index 879a421..8d182a4 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -365,6 +365,10 @@ static int amba_read_periphid(struct amba_device *dev)
>         if (!tmp)
>                 return -ENOMEM;
>
> +       ret = dev_pm_domain_attach(&dev->dev, true);
> +       if (ret == -EPROBE_DEFER)
> +               goto err_unmap;
> +
>         ret = amba_get_enable_pclk(dev);
>         if (ret == 0) {
>                 u32 pid, cid;
> @@ -389,6 +393,8 @@ static int amba_read_periphid(struct amba_device *dev)
>                         ret = -ENODEV;
>         }
>
> +       dev_pm_domain_detach(&dev->dev, true);
> +err_unmap:
>         iounmap(tmp);
>
>         return ret;
> --
> 1.9.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] Exynos4210: fix power domain for MDMA1 device Marek Szyprowski <m.szyprowski@samsung.com> - 2015-12-01 14:40 +0100
  [PATCH v3 3/3] ARM: amba: Properly handle devices with power domains Marek Szyprowski <m.szyprowski@samsung.com> - 2015-12-01 14:40 +0100
    Re: [PATCH v3 3/3] ARM: amba: Properly handle devices with power domains Ulf Hansson <ulf.hansson@linaro.org> - 2015-12-01 16:30 +0100
  [PATCH v3 2/3] ARM: amba: Move reading of periphid to amba_match() Marek Szyprowski <m.szyprowski@samsung.com> - 2015-12-01 14:40 +0100
    Re: [PATCH v3 2/3] ARM: amba: Move reading of periphid to amba_match() Ulf Hansson <ulf.hansson@linaro.org> - 2015-12-01 16:30 +0100
    Re: [PATCH v3 2/3] ARM: amba: Move reading of periphid to  amba_match() Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-01 16:50 +0100
  [PATCH v3 1/3] driver core: handle -EPROBE_DEFER from bus_type.match() Marek Szyprowski <m.szyprowski@samsung.com> - 2015-12-01 14:40 +0100
    Re: [PATCH v3 1/3] driver core: handle -EPROBE_DEFER from bus_type.match() Ulf Hansson <ulf.hansson@linaro.org> - 2015-12-01 16:30 +0100

csiph-web