Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races.

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races.
Date	2015-12-01 16:20 +0100
Message-ID	<qAUSK-2T0-31@gated-at.bofh.it> (permalink)
References	<qAypc-5id-21@gated-at.bofh.it> <qAOtY-79F-9@gated-at.bofh.it> <qAUg2-2ob-19@gated-at.bofh.it> <qAUJ3-2Pr-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Mathias Nyman <mathias.nyman@linux.intel.com> writes:
> On 01.12.2015 16:32, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Mathias Nyman <mathias.nyman@linux.intel.com> writes:
>>> usb2 ports need to signal resume for 20ms before moving to U0 state.
>>
>> at least 20ms ;-) Recently, we decided to drive resume for 40ms to
>> support devices with broken FW.
>>
>
> True, but specs talk about 20ms, and I'm just trying to give some context for what's
> going on. This testpatch doesn't touch the timings.
>
> Daniel is able to trigger a USB2 xhci resume issue which I hope is fixed with this patch.
> This is especially made for his setup running a 4.3 kernel
>
> If this works I'll clean up all the "20ms" in the commit message and comments.
>
> Just noticed that xhci USB2 host initiated resume uses a hardcoded msleep(20).
> That needs to be changed to USB_RESUME_TIMEOUT at some point.
> For now I'm just interested in knowing if this patch works.
>
>>
>> this 'v2' note doesn't have to go into commit log, IMO.
>>
>
> It's going to be cleaned out as well, just there to explain to Daniel, and the world why
> a second version of the testpatch was created.

all right, thanks ;-)

-- 
balbi

Thread

[TESTPATCH v2] xhci: fix usb2 resume timing and races. Mathias Nyman <mathias.nyman@linux.intel.com> - 2015-12-01 09:30 +0100
  Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races. Felipe Balbi <balbi@ti.com> - 2015-12-01 15:40 +0100
    Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races. Mathias Nyman <mathias.nyman@linux.intel.com> - 2015-12-01 16:10 +0100
      Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races. Felipe Balbi <balbi@ti.com> - 2015-12-01 16:20 +0100
  Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races. Daniel J Blueman <daniel@quora.org> - 2015-12-05 05:10 +0100
    Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races. Mathias Nyman <mathias.nyman@linux.intel.com> - 2015-12-08 12:20 +0100

csiph-web