Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc()

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc()
Date	Tue, 01 Dec 2015 10:20:01 +0100
Message-ID	<qAPgl-7I5-7@gated-at.bofh.it> (permalink)
References	<qziFP-6i7-7@gated-at.bofh.it> <qALw5-5g0-5@gated-at.bofh.it> <qAMLw-5Zu-5@gated-at.bofh.it> <qANoe-6v3-9@gated-at.bofh.it> <qAOki-76n-9@gated-at.bofh.it>
X-Original-To	Minchan Kim <minchan@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=XLerdT3YFwuuYjmM1PM3gLPv1svAZK45PkYHCdV3VrM=; b=keQ7bLwqSIVtNJmjR99GpWHpyxCVoaOd0KyeZK1wffil2pe3yI/bJnrxKLkD2dZPoj PqAa1jrWW1rwN71x6aFN48g7+p1CofbYP86yGemk5hs9lnOh+GkGJ8AWbylHM9/3LQnm azLjP3XSlyZKi/enmpT4K3NAddCyJgBza83GXtOvpvo+qYW7xG+dpxtu9AXgC7184HrA guzc33dxwuHslqq8pjq3kqDToM4UQ/RghPERkZpTqX91VF4SOJlYa0Bac1vnEroJ8TpE Y+zYmQDMBp00NA/rYLoeBjCv5+oscgL/FjMSuRajpaDpjp8FpWfcQKDVbgHhSsEuP4SQ xiwA==
X-Received	by 10.67.1.103 with SMTP id bf7mr98028272pad.147.1448961003548; Tue, 01 Dec 2015 01:10:03 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Kyeongdon Kim <kyeongdon.kim@lge.com>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
X-Original-Date	Tue, 1 Dec 2015 18:11:04 +0900
X-Original-Message-ID	<20151201091104.GA483@swordfish>
X-Original-References	<1448597449-17579-1-git-send-email-sergey.senozhatsky@gmail.com> <20151201051652.GA894@swordfish> <565D3FCD.3060503@lge.com> <20151201071542.GB894@swordfish> <20151201081620.GA27574@bbox>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1280666

Show key headers only | View raw

On (12/01/15 17:16), Minchan Kim wrote:
> On Tue, Dec 01, 2015 at 04:15:42PM +0900, Sergey Senozhatsky wrote:
> > On (12/01/15 15:35), Kyeongdon Kim wrote:
> > [..]
> > > @test #4
> > >  kmalloc(f)
> > > __vmalloc(f)
> > > // cannot find failure both until now
> > > 
> > > log message (test #4) :
> > > <4>[  641.440468][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002190000
> > > <snip>
> > > <4>[  922.182980][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002208000
> > > <snip>
> > > <4>[  923.197593][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002020000
> > > <snip>
> > > <4>[  939.813499][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc0020a0000
> > 
> > Thanks!
> > 
> > > So,is there another problem if we remove the flag from both sides?
> > > 
> > 
> > Technically, '~__GFP_NOMEMALLOC' is what we've been doing for some time (well,
> > always); and, as Minchan noted, zsmalloc does not depend on emergency pools.
> > 
> > I vote for removal of __GFP_NOMEMALLOC from both kmalloc() and __vmalloc().
> > 
> > (user can make ->max_strm big enough to deplete emergency mem; but I tend to
> > ignore it).
> > 
> > Minchan?
> 
> Agree. Do you mind resending patches? :)

OK, will do later today. Thanks.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: Re: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() "kyeongdon.kim" <kyeongdon.kim@lge.com> - 2015-12-01 03:40 +0100
  Re: Re: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Minchan Kim <minchan@kernel.org> - 2015-12-01 05:50 +0100
    Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-12-01 06:20 +0100
      Re: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Kyeongdon Kim <kyeongdon.kim@lge.com> - 2015-12-01 07:40 +0100
        Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-12-01 08:20 +0100
          Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-12-01 08:40 +0100
          Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Minchan Kim <minchan@kernel.org> - 2015-12-01 09:20 +0100
            Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-12-01 10:20 +0100
        Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-12-01 08:30 +0100

csiph-web