Re: [PATCHv2] arm: Update all mm structures with section adjustments

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2] arm: Update all mm structures with section adjustments
Date	2015-12-01 02:20 +0100
Message-ID	<qAHLP-2RM-1@gated-at.bofh.it> (permalink)
References	<qwl7c-1Xq-11@gated-at.bofh.it> <qwCUp-57G-11@gated-at.bofh.it> <qAGmJ-1Ri-1@gated-at.bofh.it> <qAHiN-2re-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 30, 2015 at 4:42 PM, Laura Abbott <labbott@redhat.com> wrote:
> On 11/30/2015 03:40 PM, Kees Cook wrote:
>>
>> On Thu, Nov 19, 2015 at 11:10 AM, Kees Cook <keescook@chromium.org> wrote:
>>>
>>> On Wed, Nov 18, 2015 at 4:14 PM, Laura Abbott <labbott@fedoraproject.org>
>>> wrote:
>>>>
>>>> Currently, when updating section permissions to mark areas RO
>>>> or NX, the only mm updated is current->mm. This is working off
>>>> the assumption that there are no additional mm structures at
>>>> the time. This may not always hold true. (Example: calling
>>>> modprobe early will trigger a fork/exec). Ensure all mm structres
>>>> get updated with the new section information.
>>>>
>>>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>>>
>>>
>>> This looks right to me. :)
>>>
>>> Reviewed-by: Kees Cook <keescook@chromium.org>
>>>
>>> Russell, does this work for you?
>>
>>
>> Did this end up in the patch tracker? (I just sent a patch that'll
>> collide with this... I'm happy to do the fix up.)
>>
>
> I put this in the patch tracker this morning.

Ah-ha, great! I will rebase my change on to it and send a v2
(potentially with additional changes).

-Kees

>
>>
>> -Kees
>>
>
> Thanks,
> Laura



-- 
Kees Cook
Chrome OS & Brillo Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2] arm: Update all mm structures with section adjustments Laura Abbott <labbott@fedoraproject.org> - 2015-11-19 01:20 +0100
  Re: [PATCHv2] arm: Update all mm structures with section adjustments Kees Cook <keescook@chromium.org> - 2015-11-19 20:20 +0100
    Re: [PATCHv2] arm: Update all mm structures with section adjustments Kees Cook <keescook@chromium.org> - 2015-12-01 00:50 +0100
      Re: [PATCHv2] arm: Update all mm structures with section adjustments Laura Abbott <labbott@redhat.com> - 2015-12-01 01:50 +0100
        Re: [PATCHv2] arm: Update all mm structures with section adjustments Kees Cook <keescook@chromium.org> - 2015-12-01 02:20 +0100

csiph-web