Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region
Date	2015-11-30 23:40 +0100
Message-ID	<qAFh0-18d-23@gated-at.bofh.it> (permalink)
References	<qAp2x-7JK-3@gated-at.bofh.it> <qAp2x-7JK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Vignesh R <vigneshr@ti.com> [151129 21:16]:
> Add qspi memory mapped region entries for DRA7xx based SoCs. Also,
> update the binding documents for the controller to document this change.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
...
> --- a/Documentation/devicetree/bindings/spi/ti_qspi.txt
> +++ b/Documentation/devicetree/bindings/spi/ti_qspi.txt
> @@ -26,3 +26,17 @@ qspi: qspi@4b300000 {
>  	spi-max-frequency = <25000000>;
>  	ti,hwmods = "qspi";
>  };
> +
> +For dra7xx:
> +qspi: qspi@4b300000 {
> +	compatible = "ti,dra7xxx-qspi";
> +	reg = <0x4b300000 0x100>,
> +	      <0x5c000000 0x4000000>,
> +	      <0x4a002558 0x4>;
> +	reg-names = "qspi_base", "qspi_mmap",
> +		    "qspi_ctrlmod";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	spi-max-frequency = <48000000>;
> +	ti,hwmods = "qspi";
> +};

Actually none of the IO areas above are within the same interconnect target:

0x4b300000  QSPI0 address space in L3 main interconnect
0x5c000000  QSPI1 address space in L3 main interconnect
0x4a002558  CTRL_CORE_CONTROL_IO_2 in System Control Module (SCM) in L4_CFG

The first two address spaces should be two separate instances of this driver.
The CTRL_CORE_CONTROL_IO_2 needs seems like a shared clock register that
needs to be accessed using the clock framework most likely.

So not applying, this will be impossible to move to some real interconnect
driver until these issues are fixed.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R <vigneshr@ti.com> - 2015-11-30 06:20 +0100
  Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Tony Lindgren <tony@atomide.com> - 2015-11-30 23:10 +0100
    Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Tony Lindgren <tony@atomide.com> - 2015-11-30 23:40 +0100
  Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Tony Lindgren <tony@atomide.com> - 2015-11-30 23:40 +0100
    Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R <vigneshr@ti.com> - 2015-12-01 05:50 +0100
      Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Tony Lindgren <tony@atomide.com> - 2015-12-01 17:50 +0100
        Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R <vigneshr@ti.com> - 2015-12-03 11:30 +0100
          Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R <vigneshr@ti.com> - 2015-12-10 06:10 +0100
            Re: [PATCH v4 4/5] ARM: dts: DRA7: add entry for qspi mmap region Tony Lindgren <tony@atomide.com> - 2015-12-10 18:50 +0100

csiph-web