Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
Date	2015-12-01 00:00 +0100
Message-ID	<qAFAm-1gu-21@gated-at.bofh.it> (permalink)
References	<qAiX7-3AN-9@gated-at.bofh.it> <qAD5v-8hq-1@gated-at.bofh.it> <qAEEh-FH-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 30.11.2015 um 22:38 schrieb Eric W. Biederman:
> 
> There is no defined mechanism to pass network namespace information
> into /sbin/bridge-stp therefore don't even try to invoke it except
> for bridge devices in the initial network namespace.
> 
> It is possible for unprivileged users to cause /sbin/bridge-stp to be
> invoked for any network device name which if /sbin/bridge-stp does not
> guard against unreasonable arguments or being invoked twice on the same
> network device could cause problems.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Just figured that /sbin/bridge-stp is a shell script.
Network interfaces can contain a lot of funny characters,
maybe this is after all a security issue.

Thanks,
//richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

user controllable usermodehelper in br_stp_if.c Richard Weinberger <richard@nod.at> - 2015-11-29 23:50 +0100
  Re: user controllable usermodehelper in br_stp_if.c Kees Cook <keescook@chromium.org> - 2015-11-30 21:20 +0100
    [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace ebiederm@xmission.com (Eric W. Biederman) - 2015-11-30 23:00 +0100
      Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial  network namespace Stephen Hemminger <stephen@networkplumber.org> - 2015-11-30 23:20 +0100
        Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace ebiederm@xmission.com (Eric W. Biederman) - 2015-11-30 23:30 +0100
      Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial  network namespace Richard Weinberger <richard@nod.at> - 2015-12-01 00:00 +0100
      Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial  network namespace Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-12-01 15:20 +0100
      Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial  network namespace David Miller <davem@davemloft.net> - 2015-12-03 06:00 +0100
        Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial  network namespace Kees Cook <keescook@chromium.org> - 2015-12-08 22:00 +0100
    Re: user controllable usermodehelper in br_stp_if.c Richard Weinberger <richard@nod.at> - 2015-12-01 00:10 +0100

csiph-web