Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used.

From	Dmitry Krivenok <krivenok.dmitry@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used.
Date	2015-11-30 21:40 +0100
Message-ID	<qADoS-8nQ-15@gated-at.bofh.it> (permalink)
References	<qyri9-3QA-7@gated-at.bofh.it> <qyOHM-2Bf-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> First of all, please, split per subsystem / driver. Here seems one
> file — one patch.

Sure, will do.

>>      if (size > max_size) {
>>          dev_err(pcie->dev,
>> -            "res size 0x%pap exceeds max supported size 0x%llx\n",
>> +            "res size %pap exceeds max supported size 0x%llx\n",
>
> %pa also works.
>

Yes, but AFAIK %pap and %pa are identical (see address_val() in lib/vsprintf.c),
so I'm not sure I understand your comment.

Did you mean that %pa should be used instead of %pap?
I see that %pa is used much more often than %pap, but I didn't find any
evidence that %pap is deprecated.

Thanks,
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] Remove unneeded "0x" when %pa formatting is used. Dmitry Krivenok <krivenok.dmitry@gmail.com> - 2015-11-24 20:20 +0100
  Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used. Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-25 21:20 +0100
    Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used. Dmitry Krivenok <krivenok.dmitry@gmail.com> - 2015-11-30 21:40 +0100

csiph-web