Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition
Date	2015-11-30 20:50 +0100
Message-ID	<qACCu-7Qy-9@gated-at.bofh.it> (permalink)
References	<qzzQm-kA-7@gated-at.bofh.it> <qzzQm-kA-9@gated-at.bofh.it> <qzzQm-kA-5@gated-at.bofh.it> <qzOml-1rG-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Nov 28, 2015 at 03:05:26PM +0100, Rafał Miłecki wrote:
> On 27 November 2015 at 23:33, Brian Norris <computersforpeace@gmail.com> wrote:
> > On Fri, Nov 27, 2015 at 10:25:55AM +0100, Rafał Miłecki wrote:
> >> On 26 November 2015 at 09:05, Rafał Miłecki <zajec5@gmail.com> wrote:
> >> > Fixes: 1976367173a4 ("mtd: spi-nor: embed struct mtd_info within struct spi_nor")
> >
> > I'm not 100% sure, but I thought I recall the -stable folks picking up
> > for-linus commits just based on the 'Fixes:' tags. I feel like that
> > isn't always ideal, though.
> 
> I'm confused. Do you mean I shouldn't include it?

No, the 'Fixes' usage is fine. I'm just not clear what importance is
placed on it by others.

> Do you have a reference to more detailed Fixes usage? All I found is
> info in Documentation/SubmittingPatches:
> > If your patch fixes a bug in a specific commit, e.g. you found an issue using
> > git-bisect, please use the 'Fixes:' tag
> I think 'Fixes' usage is OK in this case.

I don't have any better reference. Perhaps I'm completely mistaken, and
'Fixes' is never taken as the sole source of for-stable annotation.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info  definition Brian Norris <computersforpeace@gmail.com> - 2015-11-27 23:40 +0100
  Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition Rafał Miłecki <zajec5@gmail.com> - 2015-11-28 15:10 +0100
    Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info  definition Brian Norris <computersforpeace@gmail.com> - 2015-11-30 20:50 +0100

csiph-web