Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force

Path	csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force
Date	Sun, 29 Nov 2015 13:50:01 +0100
Message-ID	<qA9At-6e2-1@gated-at.bofh.it> (permalink)
References	<qzsYy-4AQ-25@gated-at.bofh.it> <qzthU-4Hv-27@gated-at.bofh.it>
X-Original-To	Emil Velikov <emil.l.velikov@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=kpZlS+/DqiHBOcqu0PkBT0mlM9G3JWBU2CtCpzW4ST0=; b=O9MG00o1QqvhLOsokaWk3OZOi3ORAWsPzUuA+gsYsmjyfIoa+6q1Snx7dEeGqHOEmR r17YY0AUyvQnPHpSF1OgFaAIa5RxbNyzdX6H3WlJDNJrpeX1nOITlByxPND7DgK53lty XZgVARL6FVVuZNOHyIK3aT45ss1WDcrnBD9oQ=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-type :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kpZlS+/DqiHBOcqu0PkBT0mlM9G3JWBU2CtCpzW4ST0=; b=BM8qPdEAfyT6mX/VKpJyjyqsZHRl29O8V5QPral7+VKSKJaQLQs574Zcag0pySGPUj 9bX9uBLoELESbC7OZo49K1Ho1BY7zV04q77jzu87rOamAhQQhYausAg8pQl3ubQu9Ki6 YgJEplUBTX6E+0vfoZ6meyCNA5pdvlviAkeOcQT2sy3ByuYkQFBmuPpgL0KVH/9Wbv6A T49vViz3dCk4Qm0pvSWwzatWWdXpjWoHa6pcEj3nIM0IDbomIHFilNJEAbsfMoT/bxVJ /l48F8YvcCZmgPxxAb6/GcNUVYh+aQPGs+fvYLsSW6MyNiXgx8KhClqG3a6CJrPlNSBX u18Q==
X-Gm-Message-State	ALoCoQlm8ICR4tqIVdynjosxocMHg7EqckMAzP6iDT68/CExVmHWGn9e3033ZKLxn3rGFqqgcy92
X-Received	by 10.28.63.204 with SMTP id m195mr20745750wma.11.1448801345743; Sun, 29 Nov 2015 04:49:05 -0800 (PST)
Mail-Followup-To	Emil Velikov <emil.l.velikov@gmail.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>, DRI Development <dri-devel@lists.freedesktop.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
X-Operating-System	Linux phenom 4.1.0-2-amd64
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>, DRI Development <dri-devel@lists.freedesktop.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>
X-Original-Date	Sun, 29 Nov 2015 13:49:03 +0100
X-Original-Message-ID	<20151129124903.GB17050@phenom.ffwll.local>
X-Original-References	<1448637005-3847-1-git-send-email-daniel.vetter@ffwll.ch> <CACvgo5135MWO4Si9xYjW4PsmUYdadtPA++X12g2Y76KtRe85kQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1279328

Show key headers only | View raw

On Fri, Nov 27, 2015 at 03:29:52PM +0000, Emil Velikov wrote:
> On 27 November 2015 at 15:10, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > This allows us to ditch a ton of ugly #ifdefs from a bunch of drm modeset
> > drivers.
> >
> > v2: Make the dummy function actually return a sane value, spotted by
> > Ville.
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  drivers/gpu/drm/ast/ast_drv.c         | 2 --
> >  drivers/gpu/drm/cirrus/cirrus_drv.c   | 2 --
> >  drivers/gpu/drm/i915/i915_drv.c       | 2 --
> >  drivers/gpu/drm/mgag200/mgag200_drv.c | 2 --
> >  drivers/gpu/drm/nouveau/nouveau_drm.c | 2 --
> >  drivers/gpu/drm/qxl/qxl_drv.c         | 2 --
> >  drivers/gpu/drm/radeon/radeon_drv.c   | 2 --
> >  include/linux/console.h               | 2 ++
> 
> The new drivers seems to be missing the conversion. Namely amdgpu and
> virtio_gpu.

Just shows how old this patch is ;-) And it's not going to cause a
problem since this patch simply makes the #ifdef redundant.

Greg, do you prefer a respin or a fixup patch?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force Daniel Vetter <daniel.vetter@ffwll.ch> - 2015-11-27 16:20 +0100
  Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force Emil Velikov <emil.l.velikov@gmail.com> - 2015-11-27 16:40 +0100
    Re: [PATCH RESEND 1/2] vgacon: dummy implementation for  vgacon_text_force Daniel Vetter <daniel@ffwll.ch> - 2015-11-29 13:50 +0100

csiph-web