Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1279318

Re: block: Always check queue limits for cloned requests

Show all headers | View raw

On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote:
> On Thu, Nov 26 2015 at  2:46am -0500,
> Hannes Reinecke <hare@suse.de> wrote:
> 
> > When a cloned request is retried on other queues it always needs
> > to be checked against the queue limits of that queue.
> > Otherwise the calculations for nr_phys_segments might be wrong,
> > leading to a crash in scsi_init_sgtable().
> > 
> > To clarify this the patch renames blk_rq_check_limits()
> > to blk_cloned_rq_check_limits() and removes the symbol
> > export, as the new function should only be used for
> > cloned requests and never exported.
> > 
> > Cc: Mike Snitzer <snitzer@redhat.com>
> > Cc: Ewan Milne <emilne@redhat.com>
> > Cc: Jeff Moyer <jmoyer@redhat.com>
> > Signed-off-by: Hannes Reinecke <hare@suse.de>
> 
> Patch looks good.  Thanks for getting to the bottom of this.
> 
> Jens, please add these extra tags when you pick this up:
> 
> Fixes: e2a60da74 ("block: Clean up special command handling logic")
> Cc: stable@vger.kernel.org # 3.7+
> Acked-by: Mike Snitzer <snitzer@redhat.com>

I'm still seeing the issue (BUG at drivers/scsi/scsi_lib.c:1096!) even
with this patch applied.

markus@x4 linux % git describe
v4.4-rc2-215-g081f3698e606

-- 
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] block: Always check queue limits for cloned requests Hannes Reinecke <hare@suse.de> - 2015-11-26 08:50 +0100
  Re: block: Always check queue limits for cloned requests Mike Snitzer <snitzer@redhat.com> - 2015-11-26 14:20 +0100
    Re: block: Always check queue limits for cloned requests Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-11-29 13:00 +0100
      Re: block: Always check queue limits for cloned requests Hannes Reinecke <hare@suse.de> - 2015-11-29 16:50 +0100
        Re: block: Always check queue limits for cloned requests Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-11-29 17:20 +0100
          Re: block: Always check queue limits for cloned requests Mike Snitzer <snitzer@redhat.com> - 2015-11-29 18:00 +0100
            Re: block: Always check queue limits for cloned requests Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-11-29 18:10 +0100
              Re: block: Always check queue limits for cloned requests Ming Lei <tom.leiming@gmail.com> - 2015-11-30 07:20 +0100
                Re: block: Always check queue limits for cloned requests Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-11-30 08:20 +0100
              Re: block: Always check queue limits for cloned requests Hannes Reinecke <hare@suse.de> - 2015-11-30 07:50 +0100

csiph-web