Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1279290

[tip:perf/core] perf test: 'unwind' test should create kernel maps

Show all headers | View raw

Commit-ID:  9bdcede563a831f139b5fc872f028ef844a7462e
Gitweb:     http://git.kernel.org/tip/9bdcede563a831f139b5fc872f028ef844a7462e
Author:     Jiri Olsa <jolsa@redhat.com>
AuthorDate: Fri, 27 Nov 2015 09:21:21 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 27 Nov 2015 13:14:26 -0300

perf test: 'unwind' test should create kernel maps

The 'perf test unwind' is failing because it forgot to create the kernel
maps, fix it.

After the patch:

  # perf test unwind
  40: Test dwarf unwind         : Ok

Reported-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/20151127082121.GA24503@krava.brq.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/dwarf-unwind.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/perf/tests/dwarf-unwind.c b/tools/perf/tests/dwarf-unwind.c
index b2357e8..3cce13b1 100644
--- a/tools/perf/tests/dwarf-unwind.c
+++ b/tools/perf/tests/dwarf-unwind.c
@@ -173,6 +173,11 @@ int test__dwarf_unwind(int subtest __maybe_unused)
 		return -1;
 	}
 
+	if (machine__create_kernel_maps(machine)) {
+		pr_err("Failed to create kernel maps\n");
+		return -1;
+	}
+
 	callchain_param.record_mode = CALLCHAIN_DWARF;
 
 	if (init_live_machine(machine)) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

perf test unwind failing Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-26 21:50 +0100
  Re: perf test unwind failing Jiri Olsa <jolsa@redhat.com> - 2015-11-27 09:30 +0100
    Re: perf test unwind failing Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-27 17:10 +0100
      Re: perf test unwind failing Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-27 17:20 +0100
        Re: perf test unwind failing Jiri Olsa <jolsa@redhat.com> - 2015-11-29 21:20 +0100
    [tip:perf/core] perf test: 'unwind'   test should create kernel maps tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-11-29 09:00 +0100

csiph-web