Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method

From	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method
Date	2015-11-29 04:00 +0100
Message-ID	<qA0nv-oN-1@gated-at.bofh.it> (permalink)
References	<qk5AR-4FE-3@gated-at.bofh.it> <qzST0-48t-7@gated-at.bofh.it> <qzYvo-7HB-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andy Shevchenko wrote:
> On Sat, Nov 28, 2015 at 8:58 PM, Brent Taylor <motobud@gmail.com> wrote:
> > Whats the status on this patch?  I don't see it on patchwork anymore
> > nor is it in any of the git trees I checked.
> >
> 
> You forget to use kvfree() instead of kfree() in core.c.
> 

In addition to that, I think you can do like below.

	if (&ar->fw == fw)
		*fw = vmalloc(fw_entry->size);
	else
		*fw = kmalloc(fw_entry->size, GFP_KERNEL);
	if (*fw == NULL)
		ret = -ENOMEM;
	else
		memcpy(*fw, fw_entry->data, fw_entry->size);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method Brent Taylor <motobud@gmail.com> - 2015-11-28 20:00 +0100
  Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-29 02:00 +0100
    Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2015-11-29 04:00 +0100

csiph-web