Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686

From	Josh Boyer <jwboyer@fedoraproject.org>
Newsgroups	linux.kernel
Subject	Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686
Date	2015-09-17 02:00 +0200
Message-ID	<q9uMh-2R6-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <pQnrY-38Z-1@gated-at.bofh.it> <pQpk5-5QM-3@gated-at.bofh.it> <pQpN8-6ow-5@gated-at.bofh.it> <pQrOW-Of-5@gated-at.bofh.it> <pQvpv-5ZP-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jul 26, 2015 at 10:42 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote:
>> I can confirm your patch working. However, it might be good to use yours
>> and Thomas' in combination to solve this properly.
>
> Please do not top-post.
>
> We could use Thomas' too although from looking at it,
> detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing
> for each CPU. By the time we hit cache_shared_cpu_map_remove() in
> free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still
> allocated. We kfree them in the next step only.
>
> But I like the moving of the check from the CPU hotplug callback to
> free_cache_attributes().
>
> So I'll merge the two patches and write up a proper commit message,
> unless someone objects.
>
> I'll add your Tested-by too.

Did this actually happen?  I don't see either fix in Linus' tree yet,
the merge window is closed, and the bug happens on 4.1 and 4.2 stable
kernels..

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs  code to generic infrastructure' on AMD i686 Josh Boyer <jwboyer@fedoraproject.org> - 2015-09-17 02:00 +0200
  Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs  code to generic infrastructure' on AMD i686 Philip Müller <philm@manjaro.org> - 2015-09-17 07:40 +0200
  Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs  code to generic infrastructure' on AMD i686 Borislav Petkov <bp@alien8.de> - 2015-09-17 09:20 +0200
    Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs  code to generic infrastructure' on AMD i686 Greg KH <gregkh@linuxfoundation.org> - 2015-09-17 15:00 +0200

csiph-web