Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1226553

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

Show all headers | View raw

On 09/16/15 08:54, Krzysztof Kozlowski wrote:
> On 16.09.2015 08:35, Kukjin Kim wrote:
>> On 09/13/15 18:32, Krzysztof Kozlowski wrote:
>>> The LEDs on Odroid XU3 family boards could not properly probe because PWM
>>> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
>>> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
>>> for MIPI probably is redundant because board does not have MIPI
>>> connector available).
>>>
>>> This fixes warnings on dmesg:
>>> [    4.838712] samsung-pwm 12dd0000.pwm: tried to request PWM channel 1 without output
>>> [    4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
>>> [    4.838767] leds_pwm: probe of pwmleds failed with error -22
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>>>    just on current next.
>>> ---
>>
>> Applied, thanks.
>>
> 
> Thanks. This is actually a candidate for current v4.3 cycle. It fixes
> issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26:
> The offending commit b685d540cc26 was merged in v4.3.
> I forgot to add "fixes" tag.
> 	Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for exynos5422-odroidxu3")
> 
> Can you send it to arm-soc during this cycle?
> 
Why not? Will do it ;-)

> For current v4.3 Bartlomiej's patch is also an important candidate:
> "ARM: dts: add suspend opp to exynos4412"
> 
Thanks for gentle reminder.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3 Krzysztof Kozlowski <k.kozlowski.k@gmail.com> - 2015-09-13 11:40 +0200
  Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3 Kukjin Kim <kgene@kernel.org> - 2015-09-16 01:40 +0200
    Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-16 02:00 +0200
      Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3 Kukjin Kim <kgene@kernel.org> - 2015-09-17 01:00 +0200

csiph-web