Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1226380

Re: [rtc-linux] [PATCH] Fixed ds1390_get_reg returned value

From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [rtc-linux] [PATCH] Fixed ds1390_get_reg returned value
Date 2015-09-16 20:20 +0200
Message-ID <q9ptg-3Ot-33@gated-at.bofh.it> (permalink)
References <q9ptg-3Ot-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

Your patch is not properly fomatted, it as probably been mangled by your
mailer can you resend it properly?

Thanks,

On 16/09/2015 at 17:51:17 +0200, Ivan Grimaldi wrote :
> spi_write_then_read puts in rx_buf the received data starting from the
> first byte of the rx_buf for n_rx bytes.
> 
> Signed-off-by: Ivan Grimaldi <grimaldi.ivan@gmail.com>
> ---
> diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
> index e67bfcb..a4303b4 100644
> --- a/drivers/rtc/rtc-ds1390.c
> +++ b/drivers/rtc/rtc-ds1390.c
> @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned
> char address,
>         if (status != 0)
>                 return status;
> 
> -       *data = chip->txrx_buf[1];
> +       *data = chip->txrx_buf[0];
> 
>         return 0;
>  }
> 
> -- 
> -- 
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> --- 
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [rtc-linux] [PATCH] Fixed ds1390_get_reg returned value Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-16 20:20 +0200

csiph-web