Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1226308
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") |
| Date | 2015-09-16 19:20 +0200 |
| Message-ID | <q9oxd-2sA-29@gated-at.bofh.it> (permalink) |
| References | <q9nUv-1tZ-37@gated-at.bofh.it> <q9odQ-1QO-17@gated-at.bofh.it> <q9onv-2h2-1@gated-at.bofh.it> <q9oxd-2sA-31@gated-at.bofh.it> |
| Organization | ARM Ltd |
On 16/09/15 18:10, Jisheng Zhang wrote:
> Dear Thomas,
>
> On Thu, 17 Sep 2015 00:59:08 +0800
> Jisheng Zhang <jszhang@marvell.com> wrote:
>
>> On Wed, 16 Sep 2015 18:52:41 +0200
>> Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>>> On Thu, 17 Sep 2015, Jisheng Zhang wrote:
>>>
>>>> Hi Marc,
>>>>
>>>> Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a
>>>> guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one
>>>> GIC, the secondary irq controller is Synopsys DW iCtl:
>>>> drivers/irqchip/irq-dw-apb-ictl.c
>>>>
>>>> So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns
>>>> false. The logic in cascading_gic_irq() doesn't take cascaded irq controller
>>>> which is provided by non-gic controllers.
>>>
>>> I have a fix pending for this in
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq
>>>
>>> 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag
>>>
>>> Can you please give that a try?
>>
>> Sure, Will try and get back to you
>
> Good news! The regression is fixed, cascaded irq works again!
>
> Feel free to add
>
> Tested-by: Jisheng Zhang <jszhang@marvell.com>
Ah, excellent. Probably a case of handler_data being reused... Thanks a
lot for testing this!
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 18:40 +0200
Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 18:50 +0200
Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Marc Zyngier <marc.zyngier@arm.com> - 2015-09-16 19:00 +0200
Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Thomas Gleixner <tglx@linutronix.de> - 2015-09-16 19:00 +0200
Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 19:10 +0200
Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Marc Zyngier <marc.zyngier@arm.com> - 2015-09-16 19:20 +0200
Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 19:20 +0200
Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Linus Walleij <linus.walleij@linaro.org> - 2015-09-17 23:00 +0200
csiph-web