Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1226251
| From | Christian König <deathsimple@vodafone.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation |
| Date | 2015-09-16 18:30 +0200 |
| Message-ID | <q9nKQ-1iB-57@gated-at.bofh.it> (permalink) |
| References | <pUKT0-21E-5@gated-at.bofh.it> <pUL2G-2d0-15@gated-at.bofh.it> <q9hFo-Ro-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 16.09.2015 11:56, Andrzej Hajda wrote: > Ping. > > Regards > Andrzej > > On 08/07/2015 09:59 AM, Andrzej Hajda wrote: >> The patch was generated using fixed coccinelle semantic patch >> scripts/coccinelle/api/memdup.cocci [1]. >> >> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Somehow missed that. Patch is Reviewed-by: Christian König <christian.koenig@amd.com>. Regards, Christian. >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> index 8da6424..94bd992 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata, >> if (metadata == NULL) >> return -EINVAL; >> >> - buffer = kzalloc(metadata_size, GFP_KERNEL); >> + buffer = kmemdup(metadata, metadata_size, GFP_KERNEL); >> if (buffer == NULL) >> return -ENOMEM; >> >> - memcpy(buffer, metadata, metadata_size); >> - >> kfree(bo->metadata); >> bo->metadata_flags = flags; >> bo->metadata = buffer; > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation Christian König <deathsimple@vodafone.de> - 2015-09-16 18:30 +0200 Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation Alex Deucher <alexdeucher@gmail.com> - 2015-09-21 23:40 +0200
csiph-web