Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1226170

Re: [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle

Show all headers | View raw

On Wed, Sep 16, 2015 at 03:23:21PM +0100, Jisheng Zhang wrote:
> Currently, if cpuidle is disabled or not supported, powertop reports
> zero wakeups and zero events. This is due to the cpu_idle tracepoints
> are missing.
> 
> This patch is to make cpu_idle tracepoints always available even if
> cpuidle is disabled or not supported.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>

Is there a reason why this code cannot be moved to the generic idle loop ?

Thanks,
Lorenzo

> ---
>  arch/arm64/kernel/process.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> index 223b093..f75b540 100644
> --- a/arch/arm64/kernel/process.c
> +++ b/arch/arm64/kernel/process.c
> @@ -44,6 +44,7 @@
>  #include <linux/hw_breakpoint.h>
>  #include <linux/personality.h>
>  #include <linux/notifier.h>
> +#include <trace/events/power.h>
>  
>  #include <asm/compat.h>
>  #include <asm/cacheflush.h>
> @@ -75,8 +76,10 @@ void arch_cpu_idle(void)
>  	 * This should do all the clock switching and wait for interrupt
>  	 * tricks
>  	 */
> +	trace_cpu_idle_rcuidle(1, smp_processor_id());
>  	cpu_do_idle();
>  	local_irq_enable();
> +	trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
>  }
>  
>  #ifdef CONFIG_HOTPLUG_CPU
> -- 
> 2.5.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 16:30 +0200
  Re: [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2015-09-16 16:50 +0200
    Re: [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 17:00 +0200
      Re: [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 17:20 +0200
        Re: [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2015-09-16 18:20 +0200
          Re: [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 19:10 +0200

csiph-web