[PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)

From	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)
Date	2015-09-16 15:20 +0200
Message-ID	<q9kMV-5w2-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The offending commit accidentally replaces an atomic_clear with an
atomic_or instead of an atomic_andnot in kvm_s390_vcpu_request_handled.
The symptom is that kvm guests on s390 hang on startup.
This patch simply replaces the incorrect atomic_or with atomic_andnot

Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
---
 arch/s390/kvm/kvm-s390.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index c91eb94..49e76be 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -1574,7 +1574,7 @@ static void kvm_s390_vcpu_request(struct kvm_vcpu *vcpu)
 
 static void kvm_s390_vcpu_request_handled(struct kvm_vcpu *vcpu)
 {
-	atomic_or(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
+	atomic_andnot(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
 }
 
 /*
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage) "Jason J. Herne" <jjherne@linux.vnet.ibm.com> - 2015-09-16 15:20 +0200
  Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace  atomic_{set,clear}_mask() usage) Christian Borntraeger <borntraeger@de.ibm.com> - 2015-09-16 16:40 +0200
    Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace  atomic_{set,clear}_mask() usage) Paolo Bonzini <pbonzini@redhat.com> - 2015-09-16 16:40 +0200
  Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace  atomic_{set,clear}_mask() usage) Peter Zijlstra <peterz@infradead.org> - 2015-09-16 16:50 +0200
  Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace  atomic_{set,clear}_mask() usage) Cornelia Huck <cornelia.huck@de.ibm.com> - 2015-09-16 16:50 +0200

csiph-web