Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1225951
| From | Robert Baldyga <r.baldyga@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 10/26] usb: gadget: f_mass_storage: eliminate abuse of ep->driver data |
| Date | 2015-09-16 12:20 +0200 |
| Message-ID | <q9hYM-1tT-63@gated-at.bofh.it> (permalink) |
| References | <q9hYK-1tT-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Since ep->driver_data is not used for endpoint claiming, neither for
enabled/disabled state storing, we can reduce number of places where
we read or modify it's value, as now it has no particular meaning for
function or framework logic.
In case of f_mass_storage we only need to store in ep->driver_data
pointer to struct fsg_common, which is used in bulk_in_complete() and
bulk_out_complete() callbacks. All other uses of ep->driver_data are now
meaningless and can be safely removed.
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
drivers/usb/gadget/function/f_mass_storage.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
index a6eb537..5ae7473 100644
--- a/drivers/usb/gadget/function/f_mass_storage.c
+++ b/drivers/usb/gadget/function/f_mass_storage.c
@@ -2258,12 +2258,10 @@ reset:
/* Disable the endpoints */
if (fsg->bulk_in_enabled) {
usb_ep_disable(fsg->bulk_in);
- fsg->bulk_in->driver_data = NULL;
fsg->bulk_in_enabled = 0;
}
if (fsg->bulk_out_enabled) {
usb_ep_disable(fsg->bulk_out);
- fsg->bulk_out->driver_data = NULL;
fsg->bulk_out_enabled = 0;
}
@@ -3070,13 +3068,11 @@ static int fsg_bind(struct usb_configuration *c, struct usb_function *f)
ep = usb_ep_autoconfig(gadget, &fsg_fs_bulk_in_desc);
if (!ep)
goto autoconf_fail;
- ep->driver_data = fsg->common; /* claim the endpoint */
fsg->bulk_in = ep;
ep = usb_ep_autoconfig(gadget, &fsg_fs_bulk_out_desc);
if (!ep)
goto autoconf_fail;
- ep->driver_data = fsg->common; /* claim the endpoint */
fsg->bulk_out = ep;
/* Assume endpoint addresses are the same for both speeds */
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/26] usb: gadget: encapsulate ep enable/disable Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 03/26] usb: gadget: epautoconf: add usb_ep_autoconfig_release() function Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 11/26] usb: gadget: f_midi: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 10/26] usb: gadget: f_mass_storage: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 08/26] usb: gadget: f_hid: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 20/26] usb: gadget: f_uac1: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 23/26] usb: gadget: u_ether: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 12/26] usb: gadget: f_ncm: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 16/26] usb: gadget: f_rndis: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 18/26] usb: gadget: f_sourcesink: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 26/26] usb: gadget: legacy: tcm: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:20 +0200 [PATCH v2 09/26] usb: gadget: f_loopback: eliminate abuse of ep->driver data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:30 +0200 [PATCH v2 04/26] usb: gadget: introduce 'enabled' flag in struct usb_ep Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:30 +0200 [PATCH v2 02/26] usb: gadget: f_ncm: obtain cdev from function instead of driver_data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:30 +0200 [PATCH v2 01/26] usb: gadget: fix few outdated comments Robert Baldyga <r.baldyga@samsung.com> - 2015-09-16 12:30 +0200
csiph-web