Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225701

Re: [PATCH v2 1/2] KVM: nVMX: enhance allocate/free_vpid to handle shadow vpid

Show all headers | View raw

On 9/15/15 8:54 PM, Paolo Bonzini wrote:
>
> On 15/09/2015 12:30, Wanpeng Li wrote:
>> +	if (!nested) {
>> +		vpid = find_first_zero_bit(vmx_vpid_bitmap, VMX_NR_VPIDS);
>> +		if (vpid < VMX_NR_VPIDS) {
>>   		vmx->vpid = vpid;
>>   		__set_bit(vpid, vmx_vpid_bitmap);
>> +		}
>> +	} else {
>> +		vpid = find_first_zero_bit(vmx_vpid_bitmap, VMX_NR_VPIDS);
>> +		if (vpid < VMX_NR_VPIDS) {
>> +			vmx->nested.vpid02 = vpid;
>> +			__set_bit(vpid, vmx_vpid_bitmap);
>> +		}
> Messy indentation, and a lot of duplicate code.  Can you instead have
> (which I think was Jan's suggestion too):
>
> static int allocate_vpid(void);
> static void free_vpid(int vpid);

I see, done in v3.

>
> That said, I like the simple solution to the "too many VPIDs for each L1
> VCPU" processor.

Thanks. :-)

Regards,
Wanpeng Li

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] KVM: nVMX: enhance allocate/free_vpid to handle shadow  vpid Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-15 12:40 +0200
  Re: [PATCH v2 1/2] KVM: nVMX: enhance allocate/free_vpid to handle  shadow vpid Paolo Bonzini <pbonzini@redhat.com> - 2015-09-15 15:00 +0200
    Re: [PATCH v2 1/2] KVM: nVMX: enhance allocate/free_vpid to handle  shadow vpid Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-16 06:00 +0200

csiph-web