Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1225671
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG |
| Date | 2015-09-16 04:10 +0200 |
| Message-ID | <q9akx-7hz-7@gated-at.bofh.it> (permalink) |
| References | <q8TD5-7zq-29@gated-at.bofh.it> <q99y9-68w-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 16-09-15, 03:43, Rafael J. Wysocki wrote:
> On Tuesday, September 15, 2015 01:42:21 PM Viresh Kumar wrote:
> > The variable 'wakeup_irq' is defined within #ifdef CONFIG_PM_SLEEP_DEBUG
> > and used outside of it. And that breaks kernel build:
> >
> > /home/viresh/linux/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq'
> > /home/viresh/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq'
> >
> > Fix it by defining the variable outside of the ifdef.
> >
> > Fixes: d1e59c235322 ("PM / sleep: Report interrupt that caused system wakeup")
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> I've applied the v11 of the Alexandra's patch that doesn't have this problem AFAICS.
For the record, as we have talked on IRC, even the v11 patch suffers
from this problem and you will be fixing it.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-15 10:20 +0200
Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG Pavel Machek <pavel@ucw.cz> - 2015-09-15 13:10 +0200
Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-16 03:20 +0200
Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-16 04:10 +0200
Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-16 04:30 +0200
Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-16 04:40 +0200
Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-16 04:30 +0200
csiph-web