Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers.

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers.
Date	2015-09-18 00:40 +0200
Message-ID	<q9Q0p-De-7@gated-at.bofh.it> (permalink)
References	<q8Gwa-5zh-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Joe Stringer <joestringer@nicira.com>
Date: Mon, 14 Sep 2015 11:14:50 -0700

> Static code analysis reveals the following bug:
> 
>         net/openvswitch/conntrack.c:281 ovs_ct_helper()
>         warn: unsigned 'protoff' is never less than zero.
> 
> This signedness bug breaks error handling for IPv6 extension headers when
> using conntrack helpers. Fix the error by using a local signed variable.
> 
> Fixes:  cae3a2627520: "openvswitch: Allow attaching helpers to ct
> action"
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers. Joe Stringer <joestringer@nicira.com> - 2015-09-14 20:20 +0200
  Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers. Pravin Shelar <pshelar@nicira.com> - 2015-09-15 02:00 +0200
  Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct  helpers. David Miller <davem@davemloft.net> - 2015-09-18 00:40 +0200

csiph-web