Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1227427

Re: [PATCH] nohz: make the idle_entrytime/idle_exittime correct

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH] nohz: make the idle_entrytime/idle_exittime correct
Date 2015-09-17 23:50 +0200
Message-ID <q9Pe2-7Ti-17@gated-at.bofh.it> (permalink)
References <q9ujg-2iU-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 16 Sep 2015, Yunhong Jiang wrote:

> Currently the idle_entrytime is updated on idle_entry, idle_exit and
> get_cpu_idle/iowait_time_us() with non-NULL parameter. This makes the
> idle_entrytime not the real entrytime anymore. The idle_exittiime is
> updated when exit tickless state, which can be idle tickless or full
> tickless.

If something calls one of the functions then the cpu is not idle. It's
running code.
 
> Change the idle_entrytime to be updated only when enter idle, the
> idle_exittime to be updated only when exit idle. Update
> the get_cpu_idle_iowait_time_us() accordingly.

And the rationale for this change is?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] nohz: make the idle_entrytime/idle_exittime correct Yunhong Jiang <yunhong.jiang@linux.intel.com> - 2015-09-17 01:30 +0200
  Re: [PATCH] nohz: make the idle_entrytime/idle_exittime correct Thomas Gleixner <tglx@linutronix.de> - 2015-09-17 23:50 +0200
    Re: [PATCH] nohz: make the idle_entrytime/idle_exittime correct Yunhong Jiang <yunhong.jiang@linux.intel.com> - 2015-09-18 20:50 +0200

csiph-web