Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1227417

[PATCH v2 4/9] [media] exynos4-is: use monotonic timestamps as advertized

Show all headers | View raw

The exynos4 fimc capture driver claims to use monotonic
timestamps but calls ktime_get_real_ts(). This is both
an incorrect API use, and a bad idea because of the y2038
problem and the fact that the wall clock time is not reliable
for timestamps across suspend or settimeofday().

This changes the driver to use the normal v4l2_get_timestamp()
function like all other drivers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/media/platform/exynos4-is/fimc-capture.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/media/platform/exynos4-is/fimc-capture.c b/drivers/media/platform/exynos4-is/fimc-capture.c
index cfebf292e15a..776ea6d78d03 100644
--- a/drivers/media/platform/exynos4-is/fimc-capture.c
+++ b/drivers/media/platform/exynos4-is/fimc-capture.c
@@ -183,8 +183,6 @@ void fimc_capture_irq_handler(struct fimc_dev *fimc, int deq_buf)
 	struct v4l2_subdev *csis = p->subdevs[IDX_CSIS];
 	struct fimc_frame *f = &cap->ctx->d_frame;
 	struct fimc_vid_buffer *v_buf;
-	struct timeval *tv;
-	struct timespec ts;
 
 	if (test_and_clear_bit(ST_CAPT_SHUT, &fimc->state)) {
 		wake_up(&fimc->irq_queue);
@@ -193,13 +191,9 @@ void fimc_capture_irq_handler(struct fimc_dev *fimc, int deq_buf)
 
 	if (!list_empty(&cap->active_buf_q) &&
 	    test_bit(ST_CAPT_RUN, &fimc->state) && deq_buf) {
-		ktime_get_real_ts(&ts);
-
 		v_buf = fimc_active_queue_pop(cap);
 
-		tv = &v_buf->vb.v4l2_buf.timestamp;
-		tv->tv_sec = ts.tv_sec;
-		tv->tv_usec = ts.tv_nsec / NSEC_PER_USEC;
+		v4l2_get_timestamp(&v_buf->vb.v4l2_buf.timestamp);
 		v_buf->vb.v4l2_buf.sequence = cap->frame_count++;
 
 		vb2_buffer_done(&v_buf->vb, VB2_BUF_STATE_DONE);
-- 
2.1.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] [media] y2038 conversion for subsystem Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
  [PATCH v2 2/9] [media] dvb: remove unused systime() function Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
  [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
    Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-18 10:10 +0200
      Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-18 11:20 +0200
        Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-18 11:30 +0200
          Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-18 11:50 +0200
            Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-18 12:00 +0200
              Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Arnd Bergmann <arnd@arndb.de> - 2015-09-18 12:10 +0200
                Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-18 12:30 +0200
  [PATCH v2 9/9] [media] omap3isp: support 64-bit version of omap3isp_stat_data Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
  [PATCH v2 5/9] [media] make VIDIOC_DQEVENT work with 64-bit time_t Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
  [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
    Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-18 09:30 +0200
      Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer Arnd Bergmann <arnd@arndb.de> - 2015-09-18 11:30 +0200
        Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer Hans Verkuil <hverkuil@xs4all.nl> - 2015-09-18 12:00 +0200
          Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer Arnd Bergmann <arnd@arndb.de> - 2015-09-18 12:20 +0200
  [PATCH v2 3/9] [media] dvb: don't use 'time_t' in event ioctl Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
  [PATCH v2 6/9] [media] use v4l2_get_timestamp where possible Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
  [PATCH v2 1/9] [media] dvb: use ktime_t for internal timeout Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200
  [PATCH v2 4/9] [media] exynos4-is: use monotonic timestamps as advertized Arnd Bergmann <arnd@arndb.de> - 2015-09-17 23:30 +0200

csiph-web