Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs
Date	2015-09-17 19:40 +0200
Message-ID	<q9Lk6-286-9@gated-at.bofh.it> (permalink)
References	<q7Vnz-4Zv-7@gated-at.bofh.it> <q7Vnz-4Zv-13@gated-at.bofh.it> <q9qpj-59A-13@gated-at.bofh.it> <q9HzR-50m-27@gated-at.bofh.it> <q9J8D-7rl-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Sep 17, 2015 at 11:10:41PM +0800, Chen-Yu Tsai wrote:
> On Thu, Sep 17, 2015 at 9:31 PM, Maxime Ripard

> >> > +           .formats        = SNDRV_PCM_FMTBIT_S16_LE |
> >> > +                             SNDRV_PCM_FMTBIT_S32_LE,
> >> > +           .sig_bits       = 24,

> >> So presumably also S24_LE (ie, 24 bits packed into a 32 bit word)?

> > Hmm, probably yes, I'll test that.

> IIRC when Emilio first wrote the driver, we tried 24 bit and no sound
> came out. Turns out it's an alignment issue. The codec's FIFO register
> is 32 bits wide, and takes the higher 24 bits as input when set to 24
> bit mode. The internal FIFO is only 24 bits wide. A20 user manual P174
> describes how the bits are copied.

> So for 24 bit audio, you would actually send it 32 bit audio samples,
> and let it truncate or drop the least significant 8 bits. This is why
> we have SNDRV_PCM_FMTBIT_S32_LE with .sig_bits = 24.

> I don't know if this is just a workaround, but a few other drivers do
> this as well, for example twl3040 and omap-mcpdm.

That's very common - it's essentially what S24_LE mode is.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] ASoC: Add support for the Allwinner A10 codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-12 18:00 +0200
  [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-12 18:00 +0200
    Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on  early Allwinner SoCs Mark Brown <broonie@kernel.org> - 2015-09-16 21:20 +0200
      Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on  early Allwinner SoCs Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-17 15:40 +0200
        Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the  on-chip codec on early Allwinner SoCs Chen-Yu Tsai <wens@csie.org> - 2015-09-17 17:20 +0200
          Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the  on-chip codec on early Allwinner SoCs Mark Brown <broonie@kernel.org> - 2015-09-17 19:40 +0200

csiph-web