Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1227206

Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug

From Marc Zyngier <marc.zyngier@arm.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug
Date 2015-09-17 18:50 +0200
Message-ID <q9KxI-W9-13@gated-at.bofh.it> (permalink)
References <q9zVE-2aZ-9@gated-at.bofh.it> <q9zVE-2aZ-7@gated-at.bofh.it>
Organization ARM Ltd

Show all headers | View raw


On 17/09/15 06:19, Yang Yingliang wrote:
> Add move_irqs() into kernel/irq/migration.c.
> So we can use it to migrate interrupts, when
> cpu is offline.
> 
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  include/linux/irq.h    |  4 +++
>  kernel/irq/migration.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 70 insertions(+)
> 
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index 6f8b340..64e3a02 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -446,6 +446,10 @@ static inline void irq_move_irq(struct irq_data *data) { }
>  static inline void irq_move_masked_irq(struct irq_data *data) { }
>  #endif
>  
> +#if defined(CONFIG_SMP) && defined(CONFIG_GENERIC_IRQ_MIGRATION) && defined(CONFIG_HOTPLUG_CPU)
> +void move_irqs(void);
> +#endif
> +

I don't think having this prototype guarded by this #if is very useful.
You can probably leave it standalone.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Yang Yingliang <yangyingliang@huawei.com> - 2015-09-17 07:30 +0200
  Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Marc Zyngier <marc.zyngier@arm.com> - 2015-09-17 18:50 +0200
    Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Thomas Gleixner <tglx@linutronix.de> - 2015-09-18 00:10 +0200
      Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-18 00:20 +0200
        Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Yang Yingliang <yangyingliang@huawei.com> - 2015-09-18 03:20 +0200

csiph-web