Re: [PATCH] workqueue: Free useless memory when disabling NUMA in wq_numa_init()

Path	csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!news.mb-net.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod
From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] workqueue: Free useless memory when disabling NUMA in wq_numa_init()
Date	Thu, 17 Sep 2015 17:40:04 +0200
Message-ID	<q9Js0-7OO-73@gated-at.bofh.it> (permalink)
References	<q9xqN-6Pu-1@gated-at.bofh.it>
X-Original-To	Xunlei Pang <xlpang@126.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=6Jj0+3oOB+Hlk25WJxCsd6PNfEajrY0kKfpAw5y16YM=; b=Xu+5Pj28sppclIn4quQIRe2PFSr2w8evFDwINX4scQW8rUR4YZedqpB/Rkz8Zy1BjG A4VgLmyDD4vwmTgz77W3Y/LvayHL65ZAzCqTnnuKt7xPiadfBErP+qu+xHoTVk3wGpkl NHuWe9jHCsqjRsyvOhQxcN9NBcUWvJTaFbJij0x8SPOnxKB44PB0rP5UdIwDOqg95Dvc TU2RFHG3/siuzBcBlV6VR5O0pMoVb/JJ/KgmDZ1zZtYgw/DB2Sc0OSarHA9MDNiLjnb1 hW/tjfNhJ1+K8vSWbQsckBGvh6UnTMurVJWD7DSx4lkcn36TMJz83b9rLcDcmhPH2X+J 44PA==
X-Received	by 10.129.41.4 with SMTP id p4mr34981456ywp.131.1442503794062; Thu, 17 Sep 2015 08:29:54 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>, Xunlei Pang <pang.xunlei@zte.com.cn>
X-Original-Date	Thu, 17 Sep 2015 11:29:51 -0400
X-Original-Message-ID	<20150917152951.GE7205@mtj.duckdns.org>
X-Original-References	<1442457835-24238-1-git-send-email-xlpang@126.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1227139

Show key headers only | View raw

Hello,

On Thu, Sep 17, 2015 at 10:43:55AM +0800, Xunlei Pang wrote:
> From: Xunlei Pang <pang.xunlei@zte.com.cn>
> 
> wq_update_unbound_numa_attrs_buf and tbl will never be used
> in case of invalid NUMA node mapping, so just free them.
> 
> Signed-off-by: Xunlei Pang <pang.xunlei@zte.com.cn>
> ---
>  kernel/workqueue.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index ca71582..22d7747 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -5197,6 +5197,13 @@ static void __init wq_numa_init(void)
>  		node = cpu_to_node(cpu);
>  		if (WARN_ON(node == NUMA_NO_NODE)) {
>  			pr_warn("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n", cpu);
> +
> +			for_each_node(node)
> +				free_cpumask_var(tbl[node]);
> +			kfree(tbl);

So, this is "either bios or arch code buggy but let's keep limping on
rather than crashing" path.  It doesn't matter whether there's
something lingering behind.  We wanna keep it as simple as possible.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] workqueue: Free useless memory when disabling NUMA in wq_numa_init() Xunlei Pang <xlpang@126.com> - 2015-09-17 04:50 +0200
  Re: [PATCH] workqueue: Free useless memory when disabling NUMA in  wq_numa_init() Tejun Heo <tj@kernel.org> - 2015-09-17 17:40 +0200

csiph-web