Re: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle
Date	2015-09-17 15:20 +0200
Message-ID	<q9Hgu-4Dp-17@gated-at.bofh.it> (permalink)
References	<q9oQz-2OP-15@gated-at.bofh.it> <q9CA9-65P-11@gated-at.bofh.it> <q9D3c-6EA-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 17 Sep 2015 16:44:24 +0800
Jisheng Zhang <jszhang@marvell.com> wrote:

> Dear Steven,
> 
> On Thu, 17 Sep 2015 16:07:44 +0800
> Jisheng Zhang <jszhang@marvell.com> wrote:
> 
> > Dear all,
> > 
> > On Thu, 17 Sep 2015 01:32:40 +0800
> > Jisheng Zhang <jszhang@marvell.com> wrote:
> > 
> > > Currently, if cpuidle is disabled or not supported, powertop reports
> > > zero wakeups and zero events. This is due to the cpu_idle tracepoints
> > > are missing.
> > > 
> > > This patch is to make cpu_idle tracepoints always available even if
> > > cpuidle is disabled or not supported.
> > > 
> > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > > ---
> > >  Since v1:
> > >    - ignore arm_pm_idle.
> > 
> > Something related: let's have a look at arch/arm/mach-omap2/pm34xx.c
> > the omap3_pm_idle(void) function, it uses trace_cpu_idle(), should we
> > use the _rcuidle version as below:
> 
> 484546509ce5 ("x86/tracing: Denote the power and cpuidle tracepoints as
> _rcuidle()") make me think we need to fix omap3_pm_idle, right?
> 

Probably. If those tracepoints can be called after rcu_idle_enter()
(see cpuidle_idle_call()), then yes.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang <jszhang@marvell.com> - 2015-09-16 19:40 +0200
  Re: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang <jszhang@marvell.com> - 2015-09-17 10:20 +0200
    Re: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang <jszhang@marvell.com> - 2015-09-17 10:50 +0200
      Re: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle Steven Rostedt <rostedt@goodmis.org> - 2015-09-17 15:20 +0200

csiph-web