Re: [PATCH V2] dummy_hcd: replace timeval with timespec64

From	Pingbo Wen <pingbo.wen@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] dummy_hcd: replace timeval with timespec64
Date	2015-09-17 13:50 +0200
Message-ID	<q9FRq-2rZ-35@gated-at.bofh.it> (permalink)
References	<q9xTP-7ER-5@gated-at.bofh.it> <q9xTP-7ER-7@gated-at.bofh.it> <q9E8W-8lc-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Thursday, September 17, 2015 05:59 PM, Peter Stuge wrote:
> WEN Pingbo wrote:
>> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
>> @@ -833,10 +833,10 @@ static const struct usb_ep_ops dummy_ep_ops = {
>>  /* there are both host and device side versions of this call ... */
>>  static int dummy_g_get_frame(struct usb_gadget *_gadget)
>>  {
>> -	struct timeval	tv;
>> +	struct timespec64 tv;
> 
> tv is very often used for timeval structs.
> 
> I suggest also changing the variable name, for example to ts, to
> avoid some possible confusion.
> 

Hi Peter,

Thanks for pointing it out, I will fix it in next version.

Pingbo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] dummy_hcd: replace timeval with timespec64 WEN Pingbo <pingbo.wen@linaro.org> - 2015-09-17 05:20 +0200
  Re: [PATCH V2] dummy_hcd: replace timeval with timespec64 Arnd Bergmann <arnd@arndb.de> - 2015-09-17 10:20 +0200
    [PATCH V3] dummy_hcd: replace timeval with timespec64 WEN Pingbo <pingbo.wen@linaro.org> - 2015-09-18 05:00 +0200
  Re: [PATCH V2] dummy_hcd: replace timeval with timespec64 Peter Stuge <peter@stuge.se> - 2015-09-17 12:00 +0200
    Re: [PATCH V2] dummy_hcd: replace timeval with timespec64 Pingbo Wen <pingbo.wen@linaro.org> - 2015-09-17 13:50 +0200

csiph-web