RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

From	Jon Maloy <jon.maloy@ericsson.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation
Date	2015-09-17 12:00 +0200
Message-ID	<q9E8W-8lc-23@gated-at.bofh.it> (permalink)
References	<pUKT0-21E-5@gated-at.bofh.it> <pUKT2-21E-57@gated-at.bofh.it> <q9hP4-1id-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Acked-by: Jon Maloy <jon.maloy@ericsson.com>

///jon

> -----Original Message-----
> From: Andrzej Hajda [mailto:a.hajda@samsung.com]
> Sent: Wednesday, 16 September, 2015 06:07
> To: Jon Maloy; Ying Xue
> Cc: Bartlomiej Zolnierkiewicz; Marek Szyprowski; linux-
> kernel@vger.kernel.org; David S. Miller; netdev@vger.kernel.org
> Subject: Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its
> implementation
> 
> Ping.
> 
> Regards
> Andrzej
> 
> On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> > The patch was generated using fixed coccinelle semantic patch
> > scripts/coccinelle/api/memdup.cocci [1].
> >
> > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
> >
> > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> > ---
> >  net/tipc/server.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/net/tipc/server.c b/net/tipc/server.c index
> > 922e04a..c187cad 100644
> > --- a/net/tipc/server.c
> > +++ b/net/tipc/server.c
> > @@ -411,13 +411,12 @@ static struct outqueue_entry
> *tipc_alloc_entry(void *data, int len)
> >  	if (!entry)
> >  		return NULL;
> >
> > -	buf = kmalloc(len, GFP_ATOMIC);
> > +	buf = kmemdup(data, len, GFP_ATOMIC);
> >  	if (!buf) {
> >  		kfree(entry);
> >  		return NULL;
> >  	}
> >
> > -	memcpy(buf, data, len);
> >  	entry->iov.iov_base = buf;
> >  	entry->iov.iov_len = len;
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its  implementation Jon Maloy <jon.maloy@ericsson.com> - 2015-09-17 12:00 +0200

csiph-web