Re: [PATCH v3 3/4] serial: samsung: introduce s3c24xx_serial_rx_drain_fifo() function

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/4] serial: samsung: introduce s3c24xx_serial_rx_drain_fifo() function
Date	2015-09-17 09:40 +0200
Message-ID	<q9BXr-55Q-3@gated-at.bofh.it> (permalink)
References	<q8XQm-55E-15@gated-at.bofh.it> <q8XQm-55E-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 15.09.2015 21:48, Robert Baldyga wrote:
> This patch introduces s3c24xx_serial_rx_drain_fifo() which reads data
> from RX FIFO and writes it to tty buffer. It also checks for special
> conditions (such as 'break') and handles it. This function has been
> separated from s3c24xx_serial_rx_chars_pio() as it contains code which
> can be used also in DMA mode.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
>  drivers/tty/serial/samsung.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)

Thanks for splitting the code. It looks good but I don't feel
experienced enough in the driver internals to give a review tag. :)

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/4] serial: samsung: introduce  s3c24xx_serial_rx_drain_fifo() function Robert Baldyga <r.baldyga@samsung.com> - 2015-09-15 14:50 +0200
  Re: [PATCH v3 3/4] serial: samsung: introduce  s3c24xx_serial_rx_drain_fifo() function Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-17 09:30 +0200
  Re: [PATCH v3 3/4] serial: samsung: introduce  s3c24xx_serial_rx_drain_fifo() function Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-17 09:40 +0200

csiph-web