Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225649

Re: [PATCH 1/1] fs: global sync to not clear error status of individual inodes

Show all headers | View raw

On 09/16/15 00:20, Tejun Heo wrote:
>> @@ -2121,7 +2121,13 @@ static void wait_sb_inodes(struct super_block *sb)
>>  		iput(old_inode);
>>  		old_inode = inode;
>>  
>> -		filemap_fdatawait(mapping);
>> +		/*
>> +		 * Wait for on-going writeback to complete
>> +		 * but not consume error status on this mapping.
>                        ^don't
> 
>> +		 * Otherwise application may fail to catch writeback error
> 
>                    mapping; otherwise,
> 
>> +		 * using fsync(2).
>> +		 */
> 
> Can you please re-flow the comment so that it's filling up to, say, 72
> or 76 or whatever column?

I'll fix them.

>> -	filemap_fdatawait(bdev->bd_inode->i_mapping);
>> +	filemap_fdatawait_keep_errors(bdev->bd_inode->i_mapping);
> 
> Maybe it'd be better to describe what's going on in detail in the
> function comment of filemat_fdatawait_keep_errors() and refer to that
> from its callers?

Thanks, that seems better.
I'll also extend function comments of filemap_fdatawait so that the
difference becomes clear.

-- 
Jun'ichi Nomura, NEC Corporation--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] fs: global sync to not clear error status of individual  inodes Junichi Nomura <j-nomura@ce.jp.nec.com> - 2015-09-15 12:00 +0200
  Re: [PATCH 1/1] fs: global sync to not clear error status of  individual inodes Andi Kleen <andi@firstfloor.org> - 2015-09-15 16:40 +0200
    Re: [PATCH 1/1] fs: global sync to not clear error status of  individual inodes Andrew Morton <akpm@linux-foundation.org> - 2015-09-16 00:10 +0200
      Re: [PATCH 1/1] fs: global sync to not clear error status of  individual inodes Junichi Nomura <j-nomura@ce.jp.nec.com> - 2015-09-16 03:10 +0200
        xfstests: test data-writeback error detection with fsync Junichi Nomura <j-nomura@ce.jp.nec.com> - 2015-09-16 12:50 +0200
  Re: [PATCH 1/1] fs: global sync to not clear error status of  individual inodes Tejun Heo <tj@kernel.org> - 2015-09-15 17:30 +0200
    Re: [PATCH 1/1] fs: global sync to not clear error status of  individual inodes Andi Kleen <andi@firstfloor.org> - 2015-09-15 19:00 +0200
    Re: [PATCH 1/1] fs: global sync to not clear error status of  individual inodes Junichi Nomura <j-nomura@ce.jp.nec.com> - 2015-09-16 03:10 +0200
      [PATCH v2] fs: global sync to not clear error status of individual  inodes Junichi Nomura <j-nomura@ce.jp.nec.com> - 2015-09-16 10:50 +0200
        Re: [PATCH v2] fs: global sync to not clear error status of  individual inodes Tejun Heo <tj@kernel.org> - 2015-09-16 19:50 +0200

csiph-web