Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1225565

Re: [PATCH v2] net: stmmac: Use msleep rather then udelay for reset delay

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2] net: stmmac: Use msleep rather then udelay for reset delay
Date 2015-09-16 00:10 +0200
Message-ID <q96Ai-1Xc-29@gated-at.bofh.it> (permalink)
References <q7D7l-3Xq-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date: Fri, 11 Sep 2015 22:25:48 +0200

> The reset delays used for stmmac are in the order of 10ms to 1 second,
> which is far too long for udelay usage, so switch to using msleep.
> 
> Practically this fixes the PHY not being reliably detected in some cases
> as udelay wouldn't actually delay for long enough to let the phy
> reliably be reset.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2] net: stmmac: Use msleep rather then udelay for reset delay Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-09-11 22:30 +0200
  Re: [PATCH v2] net: stmmac: Use msleep rather then udelay for  reset delay David Miller <davem@davemloft.net> - 2015-09-16 00:10 +0200

csiph-web