Re: [PATCH] pptp: avoid releasing the sock too early

From	Sasha Levin <sasha.levin@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pptp: avoid releasing the sock too early
Date	2015-09-15 19:40 +0200
Message-ID	<q92n1-3er-11@gated-at.bofh.it> (permalink)
References	<q8Eb0-25a-5@gated-at.bofh.it> <q8F75-3qM-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/14/2015 12:43 PM, Eric Dumazet wrote:
> Hmm, is the synchronize_rcu() in del_chan() still needed, and why it was
> not enough ?
> 
> I believe your patch might reduce the race window, but it is not clear
> it is the right fix.

You're right, I've missed the synchronize_rcu() originally. At this point
I'm certain that my patch is incorrect (so ignore it please), but I don't see
the cause of the bug either.

Let me think about it some more...

Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pptp: avoid releasing the sock too early Sasha Levin <sasha.levin@oracle.com> - 2015-09-14 17:50 +0200
  Re: [PATCH] pptp: avoid releasing the sock too early Eric Dumazet <eric.dumazet@gmail.com> - 2015-09-14 18:50 +0200
    Re: [PATCH] pptp: avoid releasing the sock too early Sasha Levin <sasha.levin@oracle.com> - 2015-09-15 19:40 +0200

csiph-web