Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225459

Re: [PATCH v3] tpm, tpm_crb: fix unaligned read of the command buffer address

Show all headers | View raw

On Tue, Sep 15, 2015 at 08:05:40PM +0300, Jarkko Sakkinen wrote:
> The command buffer address must be read with exactly two 32-bit reads.
> Otherwise, on some HW platforms, it seems that HW will abort the read
> operation, which causes CPU to fill the read bytes with 1's. Therefore,
> we cannot rely on memcpy_fromio() but must call ioread32() two times
> instead.
> 
> Also, this matches the PC Client Platform TPM Profile specification,
> which defines command buffer address with two 32-bit fields.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>  drivers/char/tpm/tpm_crb.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
> index b4564b6..c09b370 100644
> +++ b/drivers/char/tpm/tpm_crb.c
> @@ -68,7 +68,8 @@ struct crb_control_area {
>  	u32 int_enable;
>  	u32 int_sts;
>  	u32 cmd_size;
> -	u64 cmd_pa;
> +	u32 cmd_pa_low;
> +	u32 cmd_pa_high;
>  	u32 rsp_size;
>  	u64 rsp_pa;

What about rsp_pa?

>  } __packed;

As I mentioned, drop the __packed.

Otherwise:

Reviewed-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] tpm, tpm_crb: fix unaligned read of the command buffer address Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-15 19:10 +0200
  Re: [PATCH v3] tpm, tpm_crb: fix unaligned read of the command  buffer address Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-09-15 19:30 +0200
    Re: [PATCH v3] tpm, tpm_crb: fix unaligned read of the command  buffer address Jarkko Sakkinen <jarkko.sakkinen@intel.com> - 2015-09-16 09:20 +0200
      Re: [PATCH v3] tpm, tpm_crb: fix unaligned read of the command  buffer address Jarkko Sakkinen <jarkko.sakkinen@intel.com> - 2015-09-16 15:40 +0200

csiph-web