Re: [PATCH] trace-cmd: Leave out absolute addresses to fix bogus symbol resolutions

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] trace-cmd: Leave out absolute addresses to fix bogus symbol resolutions
Date	Tue, 15 Sep 2015 19:10:01 +0200
Message-ID	<q91TX-2GF-3@gated-at.bofh.it> (permalink)
References	<pSjaz-7Xm-25@gated-at.bofh.it> <q91qX-1Tn-49@gated-at.bofh.it>
X-Original-To	Jan Kiszka <jan.kiszka@siemens.com>
X-Session-Marker	726F737465647440676F6F646D69732E6F7267
X-Spam-Summary	2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3873:3874:4321:4362:4385:5007:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12043:12438:12517:12519:12555:12740:13069:13255:13311:13357:13972:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-He-Tag	shoe40_40d292ecf7932
X-Filterd-Recvd-Size	2253
X-Mailer	Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
Organization	linux.* mail to news gateway
X-Original-Cc	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 15 Sep 2015 13:00:44 -0400
X-Original-Message-ID	<20150915130044.5a88d661@gandalf.local.home>
X-Original-References	<55BB8086.9080602@siemens.com> <55F8479E.9030008@siemens.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1225449

Show key headers only | View raw

On Tue, 15 Sep 2015 18:30:22 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 2015-07-31 16:04, Jan Kiszka wrote:
> > On x86, page_fault_* tracepoints report userspace address via kernel
> > symbols because all the per-cpu variable offsets are in kallsyms,
> > occupying the lower address space. Fix this by skipping over absolute
> > addresses while processing kallsyms.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >  trace-util.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/trace-util.c b/trace-util.c
> > index 8a81dd0..da20e4c 100644
> > --- a/trace-util.c
> > +++ b/trace-util.c
> > @@ -434,8 +434,12 @@ void parse_proc_kallsyms(struct pevent *pevent,
> >  		if (mod)
> >  			mod[strlen(mod) - 1] = 0;
> >  
> > -		/* Hack for arm arch that adds a lot of bogus '$a' functions */
> > -		if (func[0] != '$')
> > +		/*
> > +		 * Hacks for
> > +		 *  - arm arch that adds a lot of bogus '$a' functions
> > +		 *  - x86-64 that reports per-cpu variable offsets as absolute
> > +		 */
> > +		if (func[0] != '$' && ch != 'A')
> >  			pevent_register_function(pevent, func, addr, mod);
> >  		free(func);
> >  		free(mod);
> > 
> 
> Ping.

Thanks for the reminder ping.

Hmm, I don't see anything marked 'A' in my kallsyms. Have a config I
can test to see what you are seeing?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] trace-cmd: Leave out absolute addresses to fix bogus  symbol resolutions Jan Kiszka <jan.kiszka@siemens.com> - 2015-09-15 18:40 +0200
  Re: [PATCH] trace-cmd: Leave out absolute addresses to fix bogus  symbol resolutions Steven Rostedt <rostedt@goodmis.org> - 2015-09-15 19:10 +0200
    Re: [PATCH] trace-cmd: Leave out absolute addresses to fix bogus  symbol resolutions Steven Rostedt <rostedt@goodmis.org> - 2015-09-15 19:20 +0200

csiph-web