Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223887

Re: [PATCH] numa-balancing: fix confusion in /proc/sys/kernel/numa_balancing

Show all headers | View raw

* Xishi Qiu <qiuxishi@huawei.com> wrote:

> We can only echo 0 or 1 > "/proc/sys/kernel/numa_balancing", usually 1 means
> enable and 0 means disable. But when echo 1, it shows the value is 65536, this
> is confusion.
> 
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
>  kernel/sched/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 3595403..e97a348 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2135,7 +2135,7 @@ int sysctl_numa_balancing(struct ctl_table *table, int write,
>  {
>  	struct ctl_table t;
>  	int err;
> -	int state = numabalancing_enabled;
> +	int state = !!numabalancing_enabled;
>  
>  	if (write && !capable(CAP_SYS_ADMIN))
>  		return -EPERM;

So in the latest scheduler tree this variable got renamed, please adjust your 
patch:

  git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core


Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] numa-balancing: fix confusion in /proc/sys/kernel/numa_balancing Xishi Qiu <qiuxishi@huawei.com> - 2015-09-14 08:30 +0200
  Re: [PATCH] numa-balancing: fix confusion in  /proc/sys/kernel/numa_balancing Ingo Molnar <mingo@kernel.org> - 2015-09-14 09:50 +0200
    Re: [PATCH] numa-balancing: fix confusion in /proc/sys/kernel/numa_balancing Xishi Qiu <qiuxishi@huawei.com> - 2015-09-15 03:40 +0200

csiph-web