Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings

From	Fengguang Wu <fengguang.wu@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings
Date	2015-09-14 09:00 +0200
Message-ID	<q8vU6-70S-27@gated-at.bofh.it> (permalink)
References	(2 earlier) <q7p4l-vH-1@gated-at.bofh.it> <q7x1U-3qq-17@gated-at.bofh.it> <q8stb-2fz-1@gated-at.bofh.it> <q8v7I-66P-3@gated-at.bofh.it> <q8vU5-70S-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 14, 2015 at 06:51:36AM +0000, Yuantian Tang wrote:
> The ARCH should have been ARM for this driver.
> Do you think this warning would go away if adding a dependency on ARM?

Yes, that may work.

Thanks,
Fengguang

> > -----Original Message-----
> > From: Fengguang Wu [mailto:fengguang.wu@intel.com]
> > Sent: Monday, September 14, 2015 12:05 PM
> > To: Tang Yuantian-B29983 <Yuantian.Tang@freescale.com>
> > Cc: Tejun Heo <tj@kernel.org>; hdegoede@redhat.com; linux-
> > ide@vger.kernel.org; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org
> > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings
> > 
> > Yuantian,
> > 
> > It's cross compiling on ARCH=openrisc.
> > 
> > Thanks,
> > Fengguang
> > 
> > On Mon, Sep 14, 2015 at 03:02:27AM +0000, Yuantian Tang wrote:
> > > Hello Tejun,
> > >
> > > The toolchain I used is:
> > > gcc version 4.8.3 20140401 (prerelease) (Linaro GCC 4.8-2014.04)
> > >
> > > I have not found this warning using this tool chain with -Wuninitialized flag.
> > >
> > > Regards,
> > > Yuantian
> > >
> > > > -----Original Message-----
> > > > From: Tejun Heo [mailto:htejun@gmail.com] On Behalf Of Tejun Heo
> > > > Sent: Friday, September 11, 2015 9:55 PM
> > > > To: Tang Yuantian-B29983 <Yuantian.Tang@freescale.com>
> > > > Cc: hdegoede@redhat.com; linux-ide@vger.kernel.org; linux-
> > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; Fengguang Wu
> > > > <fengguang.wu@intel.com>
> > > > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable
> > > > warnings
> > > >
> > > > Hello, Yuantian.
> > > >
> > > > On Fri, Sep 11, 2015 at 05:27:25AM +0000, Yuantian Tang wrote:
> > > > > Hi Tejun,
> > > > >
> > > > > Could you please take the version 1 patch?
> > > > > The version 2 patch can't address these warnings, and the version
> > > > > 1 can
> > > > definitely remove them.
> > > > > In this case, that would cause any hidden bugs, so no worries.
> > > >
> > > > Ugh... I really hate changes which are made to just work around
> > > > compiler silliness.  If this is something which goes away with newer
> > > > gcc, Fengguang can just make it as a known false positive.
> > > > Yuantian, which compiler are you using?
> > > >
> > > > Thanks.
> > > >
> > > > --
> > > > tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Tejun Heo <tj@kernel.org> - 2015-09-09 16:10 +0200
  RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Yuantian Tang <Yuantian.Tang@freescale.com> - 2015-09-10 08:20 +0200
  RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Yuantian Tang <Yuantian.Tang@freescale.com> - 2015-09-11 07:30 +0200
    Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Tejun Heo <tj@kernel.org> - 2015-09-11 16:00 +0200
      RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Yuantian Tang <Yuantian.Tang@freescale.com> - 2015-09-14 05:20 +0200
        Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Fengguang Wu <fengguang.wu@intel.com> - 2015-09-14 08:10 +0200
          RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Yuantian Tang <Yuantian.Tang@freescale.com> - 2015-09-14 09:00 +0200
            Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Fengguang Wu <fengguang.wu@intel.com> - 2015-09-14 09:00 +0200
              Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Arnd Bergmann <arnd@arndb.de> - 2015-09-14 09:50 +0200
                Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Tejun Heo <tj@kernel.org> - 2015-09-14 18:10 +0200

csiph-web