Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223794

Re: [PATCH 15/17] thermal: st: allow compile test

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Sep 11, 2015 at 10:23:35AM +0100, Lee Jones wrote:
> On Wed, 09 Sep 2015, Eduardo Valentin wrote:
> 
> > Adding COMPILE_TEST flag to st driver to facilitate
> > maintenance.
> > 
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Nicolas Boichat <drinkcat@chromium.org>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Fabian Frederick <fabf@skynet.be>
> > Cc: Wolfram Sang <wsa@the-dreams.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
> > ---
> >  drivers/thermal/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Sounds reasonable.
> 
> So long as it's been tested and nothing breaks:
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

Thanks for the review. But now checking the compilation test using bfin
as target, I see several compilation issues.

So, I am leaving this one out for now. It requires further changes.

BR,

> 
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 9069cc7..d94b4e9 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -350,7 +350,7 @@ source "drivers/thermal/samsung/Kconfig"
> >  endmenu
> >  
> >  menu "STMicroelectronics thermal drivers"
> > -depends on ARCH_STI && OF
> > +depends on (ARCH_STI || COMPILE_TEST) && OF
> >  source "drivers/thermal/st/Kconfig"
> >  endmenu
> >  
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/17] thermal: add COMPILE_TEST (on drivers) Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
  [PATCH 02/17] thermal: spear: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
    Re: [PATCH 02/17] thermal: spear: allow compile test Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-10 06:30 +0200
  [PATCH 08/17] thermal: tegra: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
    Re: [PATCH 08/17] thermal: tegra: allow compile test Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-10 08:40 +0200
  [PATCH 12/17] thermal: intel_quark: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
    Re: [PATCH 12/17] thermal: intel_quark: allow compile test Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-10 08:30 +0200
  [PATCH 11/17] thermal: intel_soc_dts: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
    Re: [PATCH 11/17] thermal: intel_soc_dts: allow compile test Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-10 08:30 +0200
  [PATCH 09/17] thermal: powerclamp: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
  [PATCH 01/17] thermal: hisi: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
  [PATCH 13/17] thermal: int340x: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
    Re: [PATCH 13/17] thermal: int340x: allow compile test Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-10 08:40 +0200
      Re: [PATCH 13/17] thermal: int340x: allow compile test Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2015-09-18 00:50 +0200
  [PATCH 17/17] thermal: ti-soc: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
  [PATCH 16/17] thermal: qcom_spmi: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
  [PATCH 14/17] thermal: exynos: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
  [PATCH 15/17] thermal: st: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
    Re: [PATCH 15/17] thermal: st: allow compile test Lee Jones <lee.jones@linaro.org> - 2015-09-11 11:30 +0200
      Re: [PATCH 15/17] thermal: st: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-14 04:20 +0200
  [PATCH 05/17] thermal: dove: allow compile test Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 06:20 +0200
  Re: [PATCH 00/17] thermal: add COMPILE_TEST (on drivers) Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-10 08:30 +0200
    Re: [PATCH 00/17] thermal: add COMPILE_TEST (on drivers) Eduardo Valentin <edubezval@gmail.com> - 2015-09-10 17:00 +0200
      Re: [PATCH 00/17] thermal: add COMPILE_TEST (on drivers) Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-10 17:40 +0200

csiph-web