[PATCH] userfaultfd: add missing mmput() in error path

From	Eric Biggers <ebiggers3@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] userfaultfd: add missing mmput() in error path
Date	2015-09-14 02:00 +0200
Message-ID	<q8plE-5Zj-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
---
 fs/userfaultfd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index 634e676..f9aeb40 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -1287,8 +1287,10 @@ static struct file *userfaultfd_file_create(int flags)
 
 	file = anon_inode_getfile("[userfaultfd]", &userfaultfd_fops, ctx,
 				  O_RDWR | (flags & UFFD_SHARED_FCNTL_FLAGS));
-	if (IS_ERR(file))
+	if (IS_ERR(file)) {
+		mmput(ctx->mm);
 		kmem_cache_free(userfaultfd_ctx_cachep, ctx);
+	}
 out:
 	return file;
 }
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] userfaultfd: add missing mmput() in error path Eric Biggers <ebiggers3@gmail.com> - 2015-09-14 02:00 +0200
  Re: [PATCH] userfaultfd: add missing mmput() in error path Andrea Arcangeli <aarcange@redhat.com> - 2015-09-15 02:10 +0200

csiph-web