[PATCH 09/26] usb: gadget: f_loopback: eliminate abuse of ep->driver data

Path	csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!nntpspool01.opticnetworks.net!aioe.org!bofh.it!news.nic.it!robomod
From	Robert Baldyga <r.baldyga@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 09/26] usb: gadget: f_loopback: eliminate abuse of ep->driver data
Date	Tue, 15 Sep 2015 16:30:05 +0200
Message-ID	<q8Zpb-7qt-87@gated-at.bofh.it> (permalink)
References	<q8Zp8-7qt-7@gated-at.bofh.it>
X-Original-To	balbi@ti.com
X-Auditid	cbfee61a-f79a06d000005c6f-b9-55f82af42ef4
X-Mailer	git-send-email 1.9.1
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFprOLMWRmVeSWpSXmKPExsVy+t9jAd0vWj9CDW6cMLKY9bKdxWLjjPWs Fgfv11s0L17PZnF51xw2i0XLWpkt1h65y27x4PBOdgcOj/1z17B79G1Zxehx/MZ2Jo/Pm+QC WKK4bFJSczLLUov07RK4MtYva2YtmMJTcedwH1sDYz9XFyMnh4SAiUT/hiVMELaYxIV769m6 GLk4hASWMkrMntnFBOH8ZJQ4OH8PG0gVm4COxJbvExhBbBEBAYn1Ly6xgxQxC1xglHi/YB07 SEJYIESifcsbZhCbRUBV4mnbcVYQm1fATeLAizZWiHVyEiePTQazOYHi+5edBKsXEnCVOHXw LvsERt4FjAyrGCVSC5ILipPScw3zUsv1ihNzi0vz0vWS83M3MYKD65nUDsaDu9wPMQpwMCrx 8Ea0fw8VYk0sK67MPcQowcGsJMIry/EjVIg3JbGyKrUoP76oNCe1+BCjNAeLkjiv7MpnoUIC 6YklqdmpqQWpRTBZJg5OqQbGA8wba5LufLt9d+qbR+unPli3kWVmn8nM+cuWXbvQMPm8l2LS 2wMG17V3JEtrB0zhUL9m426rxazWcJz1Yt4zXqk/++ewq1sYG+xxLfsYNltrI8uFW4u8jvBJ bRRtEl+x1Sw1teGMWPziwrSgX0cZvPJs3Vae2Gp+wEqvtP1vn/czXl7RnYLnlViKMxINtZiL ihMBDfKtHioCAAA=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, andrzej.p@samsung.com, Robert Baldyga <r.baldyga@samsung.com>
X-Original-Date	Tue, 15 Sep 2015 16:26:52 +0200
X-Original-Message-ID	<1442327229-28320-10-git-send-email-r.baldyga@samsung.com>
X-Original-References	<1442327229-28320-1-git-send-email-r.baldyga@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1225201

Show key headers only | View raw

Since ep->driver_data is not used for endpoint claiming, neither for
enabled/disabled state storing, we can reduce number of places where
we read or modify it's value, as now it has no particular meaning for
function or framework logic.

In case of f_hid we only need to store in ep->driver_data pointer to
struct f_loopback, as it's used in loopback_complete() callback. All
other uses of ep->driver_data are now meaningless and can be safely
removed.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
 drivers/usb/gadget/function/f_loopback.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/function/f_loopback.c b/drivers/usb/gadget/function/f_loopback.c
index 6e2fe63..300e601 100644
--- a/drivers/usb/gadget/function/f_loopback.c
+++ b/drivers/usb/gadget/function/f_loopback.c
@@ -195,12 +195,10 @@ autoconf_fail:
 			f->name, cdev->gadget->name);
 		return -ENODEV;
 	}
-	loop->in_ep->driver_data = cdev;	/* claim */
 
 	loop->out_ep = usb_ep_autoconfig(cdev->gadget, &fs_loop_sink_desc);
 	if (!loop->out_ep)
 		goto autoconf_fail;
-	loop->out_ep->driver_data = cdev;	/* claim */
 
 	/* support high speed hardware */
 	hs_loop_source_desc.bEndpointAddress =
@@ -364,8 +362,7 @@ static int loopback_set_alt(struct usb_function *f,
 	struct usb_composite_dev *cdev = f->config->cdev;
 
 	/* we know alt is zero */
-	if (loop->in_ep->driver_data)
-		disable_loopback(loop);
+	disable_loopback(loop);
 	return enable_loopback(cdev, loop);
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 09/26] usb: gadget: f_loopback: eliminate abuse of ep->driver  data Robert Baldyga <r.baldyga@samsung.com> - 2015-09-15 16:30 +0200

csiph-web