Re: [PATCH v3 02/18] of/platform: add of_platform_probe

From	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/18] of/platform: add of_platform_probe
Date	2015-09-15 15:10 +0200
Message-ID	<q8Y9J-5HB-25@gated-at.bofh.it> (permalink)
References	(3 earlier) <pWeck-17Z-61@gated-at.bofh.it> <q63Sj-5E0-55@gated-at.bofh.it> <q7thD-6pR-9@gated-at.bofh.it> <q7xbz-3R3-7@gated-at.bofh.it> <q7yAG-5N1-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11 September 2015 at 17:35, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Sep 11, 2015 at 04:06:07PM +0200, Tomeu Vizoso wrote:
>
>> Once a platform device (with the platform bus as its parent) is
>> retrieved from the deferred queue, both the parent and the device in
>> question are locked (because of the USB stuff mentioned below). If
>> that device depends on another device whose parent is the platform bus
>> and we try to probe it (useless, but I don't see a good way of
>> avoiding it) then we'll deadlock when device_attach locks that device.
>
> Ugh, that's nasty.  Trying to fix this would most likely devolve into
> trying to shove things onto the deferred list in the right order but
> that's definitely a very different solution with problems.

Well, that's effectively what my "ordered probing" series did (and
indeed didn't have this problem and parents were made sure to have
probed before their children), but if we want to have dependency
information before the probe starts, then we cannot reuse the
implementation of the DT bindings that we already have in the resource
getters as this series do.

Regards,

Tomeu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 02/18] of/platform: add of_platform_probe Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-07 14:40 +0200
  Re: [PATCH v3 02/18] of/platform: add of_platform_probe Mark Brown <broonie@kernel.org> - 2015-09-11 12:00 +0200
    Re: [PATCH v3 02/18] of/platform: add of_platform_probe Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-11 16:10 +0200
      Re: [PATCH v3 02/18] of/platform: add of_platform_probe Mark Brown <broonie@kernel.org> - 2015-09-11 17:40 +0200
        Re: [PATCH v3 02/18] of/platform: add of_platform_probe Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-15 15:10 +0200

csiph-web