Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225069

[PATCH] dummy_hcd: replace timeval with timespec64

Show all headers | View raw

The millisecond of the last second will be normal if tv_sec is
overflowed. But for y2038 consistency and demonstration purpose,
and avoiding further risks, we still need to fix it here,
to avoid similair problems.

Signed-off-by: Pingbo Wen <pingbo.wen@linaro.org>
Cc: Y2038 <y2038@lists.linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/gadget/udc/dummy_hcd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 1379ad4..7be721dad 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -833,10 +833,10 @@ static const struct usb_ep_ops dummy_ep_ops = {
 /* there are both host and device side versions of this call ... */
 static int dummy_g_get_frame(struct usb_gadget *_gadget)
 {
-	struct timeval	tv;
+	struct timespec64 tv;
 
-	do_gettimeofday(&tv);
-	return tv.tv_usec / 1000;
+	getnstimeofday64(&tv);
+	return tv.tv_nsec / 1000000L;
 }
 
 static int dummy_wakeup(struct usb_gadget *_gadget)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] dummy_hcd: replace timeval with timespec64 WEN Pingbo <pingbo.wen@linaro.org> - 2015-09-15 15:00 +0200
  Re: [Y2038] [PATCH] dummy_hcd: replace timeval with timespec64 Arnd Bergmann <arnd@arndb.de> - 2015-09-15 15:20 +0200
    Re: [Y2038] [PATCH] dummy_hcd: replace timeval with timespec64 Pingbo Wen <pingbo.wen@linaro.org> - 2015-09-15 15:50 +0200
      Re: [Y2038] [PATCH] dummy_hcd: replace timeval with timespec64 Arnd Bergmann <arnd@arndb.de> - 2015-09-15 16:10 +0200

csiph-web